[arch-dev-public] [patch] devtools/makechrootpkg: move determination of unique install files inside loop

[Ronald van Haren]

Hey guys,

Can we move the determination of unique .install files inside the loop (see
patch below). A few weeks ago I had troubles building koffice, now I had the
time to look into it. It appears that due the vast number of splitted
packages the install_files variable grew so large it was still not finished
adding variables after 12 hours. Determining the uniqueness of the .install
files inside the loop this doesn't happen anymore and it now finishes in a
couple of seconds.
I imagine this is also a problem with other splitted packages (most notably
some kde ones?)

Ronald


path below is against current git version.

--- /usr/sbin/makechrootpkg.old 2009-10-13 10:08:02.297306265 +0200
+++ /usr/sbin/makechrootpkg     2009-10-13 10:08:32.237724312 +0200
@@ -182,10 +182,9 @@
 for pkg in ${pkgname[@]}; do
     install_files+=' '
     install_files+=$(echo $install_files |sed "s/\$pkgname/$pkg/"|sed
"s/\${pkgname}/$pkg/")
+    install_files=$(eval echo $install_files |tr '[:blank:]' '\n'|sort
|uniq)
 done

-install_files=$(eval echo $install_files |tr '[:blank:]' '\n'|sort |uniq)
-
 for f in $install_files;do
     install="${f#"install="}"
     if [ "$install" != "" -a -f "$install" ]; then
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.archlinux.org/pipermail/arch-dev-public/attachments/20091013/aee87168/attachment.html>