[arch-dev-public] devtools [PATCH] 2/2

[Firmicus]

Allan McRae a écrit :
> Firmicus wrote:
>> ... and a second one.
>>
>> Cheers,
>> F
>>   
>
> Hmmm....   finding it difficult to review this one.
>
OK, let me try to help.

On my system, with a virgin makepkg.conf in the chroot, the packages
made with makechrootpkg were copied to the file /pkgdest (where / is my
main root). So clearly trailing / were needed in lines 243, 246, 255 and
258.
Secondly. the tests such as
     if [ -n "$PKGDEST" ]; then
in lines 241 and 253 were true, because $PKGDEST is by default the
string "/pkgdest". The directory /pkgdest however does not exist... so
there's a problem.

I see that there seems to be a confusion between the $PKGDEST on the
$uniondir and the one on the main system, right? Shouldn't the package
and sources be simply moved to $WORKDIR instead (as they used to iirc)?

Note that this patch applies to a commit
(486375ba0aedb185b369946fe565538c0f8e7949) that goes back to March, so I
am a bit surprised to be the first to have problems with it.

I apologize in advance if I overlooked something elementary.

F