<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Oct 24, 2013 at 10:05 AM, Dave Reisner <span dir="ltr"><<a href="mailto:d@falconindy.com" target="_blank">d@falconindy.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On Wed, Oct 23, 2013 at 11:24:45PM -0400, Eric Bélanger wrote:<br>
> The bsdtar options were in the incorrect order and objdump couldn't find the files.<br>
><br>
> Signed-off-by: Eric Bélanger <<a href="mailto:snowmaniscool@gmail.com">snowmaniscool@gmail.com</a>><br>
> ---<br>
>  <a href="http://checkpkg.in" target="_blank">checkpkg.in</a> | 4 ++--<br>
>  1 file changed, 2 insertions(+), 2 deletions(-)<br>
><br>
> diff --git a/<a href="http://checkpkg.in" target="_blank">checkpkg.in</a> b/<a href="http://checkpkg.in" target="_blank">checkpkg.in</a><br>
> index ef46399..02c6543 100644<br>
> --- a/<a href="http://checkpkg.in" target="_blank">checkpkg.in</a><br>
> +++ b/<a href="http://checkpkg.in" target="_blank">checkpkg.in</a><br>
> @@ -73,9 +73,9 @@ for _pkgname in "${pkgname[@]}"; do<br>
><br>
>       if diff "$TEMPDIR/filelist-$_pkgname"{-old,} | grep '\.so' &>/dev/null; then<br>
>               mkdir -p "$TEMPDIR/pkg"<br>
> -             bsdtar -C "$TEMPDIR" xf ../"$pkgfile" #> /dev/null<br>
> +             bsdtar x -C "$TEMPDIR" -f "$pkgfile" #> /dev/null<br>
<br>
</div>Problem here doesn't seem to be order of flags, but the missing '-'<br>
before 'xf'.<br>
<div class="HOEnZb"><div class="h5"><br></div></div></blockquote><div><br></div><div>I confirm adding a '-' in front of xf fixes it. Is that important enough to submit a new patch?<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5">
>               diff "$TEMPDIR/filelist-$_pkgname-old" "$TEMPDIR/filelist-$_pkgname" | awk '/>.*\.so/{$1 = ""; print $0}' | while read i; do<br>
> -                     echo "${i}: " "$(objdump -p "$i" | grep SONAME)"<br>
> +                     echo "${i}: " "$(objdump -p "$TEMPDIR/$i" | grep SONAME)"<br>
>               done<br>
>       else<br>
>               msg "No soname differences for $_pkgname."<br>
> --<br>
> 1.8.4.1<br>
><br>
</div></div></blockquote></div><br></div></div>