[arch-releng] [PATCH 3/3] [configs/releng] Support configurable build options via command line

[Gerardo Exequiel Pozzi]

On 08/18/2011 11:10 AM, Gerardo Exequiel Pozzi wrote:
> On 08/18/2011 07:01 AM, Dieter Plaetinck wrote:
>>> -  [chroot32] # mknod /dev/loop1032 b 7 1032 #assumed 
>>> loop.max_part=0 (by default)
>>> +  [chroot32] # mknod /dev/loop1032 b 7 1032  # assumed 
>>> loop.max_part=0 (by default) [chroot32]
>> 1 space too many? :P
> Just style ;)
>>
>>> -verbose="n"
>>> +verbose=""
>> same as:
>> verbose=
> Yes, but looks better visually :P
>>
>> or even better: verbose=0
>> then you can set verbose=1 later (possibly)
>> and check it with if ((verbose)); then
> Maybe :)
>>
>>
>> looks good to me, but maybe test a bit first before you push.
> Thanks for the feedback. Sure I need to test it (was a working before 
> going to sleep!).
>
> it would be benificial if the archiso currently in git stays stable 
> for today and maybe tomorrow.
> after the official release is done, you can break archiso :)
>
> OK. Yupiiii! :P
>>
>> Dieter
>>
>
>
Tested with some uncommon values

/usr/share/archiso/configs/releng/build.sh -N tino -V garga -L muza -D y 
-w traba -o jo build single all
and
/usr/share/archiso/configs/releng/build.sh -N tino -V garga -L muza -D y 
-w traba -o jo build dual all

Worked fine (build/boot)

total 2.1G
674M tino-garga-core-dual.iso
370M tino-garga-core-i686.iso
376M tino-garga-core-x86_64.iso
307M tino-garga-netinstall-dual.iso
180M tino-garga-netinstall-i686.iso
183M tino-garga-netinstall-x86_64.iso

Two fixes was needed:
One for checksum, I was missing passing -D for install_dir (now in master)
Other for not using trying to read $3 when not needed (for clean/purge 
commands)

I do other tests, and I will merge in fews hours.

-- 
Gerardo Exequiel Pozzi
\cos^2\alpha + \sin^2\alpha = 1