[pacman-dev] [PATCH] GPG signature support for makepkg:

[Dan McGee]

On Mon, Jun 2, 2008 at 3:27 AM,  <geoffroy.carrier at koon.fr> wrote:
> From: Geoffroy Carrier <geoffroy.carrier at koon.fr>
>
> ---
> This should be the last version I submit here.
Usually you jinx yourself when you say something like this, and you
forgot any sort of commit message above. I've fixed this locally so we
don't constantly submit back and forth, but please check this ahead of
time next time. You also didn't include a signoff on your two patches,
which is as easy as being willing to signoff on your work and
specifying the -s flag to git-commit. I've added a signoff for you
locally as well.

> I should start including support in pacman soon.
> It will rely directly on the gpg binary, and should work a lot like git.
> It has a very nice embedded "lib" to launch processes. I might embed parts of it
> in my pacman branch, as it's generic and seems very well-written.
>  doc/makepkg.conf.5.txt |    3 +++
>  etc/makepkg.conf.in    |    5 +++--
>  scripts/makepkg.sh.in  |   21 +++++++++++++++++++++
>  3 files changed, 27 insertions(+), 2 deletions(-)
>
> diff --git a/doc/makepkg.conf.5.txt b/doc/makepkg.conf.5.txt
> index 113ad14..b6f4385 100644
> --- a/doc/makepkg.conf.5.txt
> +++ b/doc/makepkg.conf.5.txt
> @@ -92,6 +92,9 @@ Options
You forgot to add !sign to the example BUILDENV array here, but I've
done that locally so no need to resubmit.

>                previous package must be available in the makepkg cache directory for
>                this to occur.
>
> +       *sign*;;
> +               Generate a PGP signature file using GnuPG.
> +
>  **DISTCC_HOSTS=**"host1 ..."::
>        If using DistCC, this is used to specify a space-delimited list of hosts
>        running in the DistCC cluster. In addition, you will want to modify your

Other than that the patch looks fine, I've started putting these
changes in a local branch that will end up in master soon enough.
Looking forward to seeing perfect PGP support in pacman/libalpm!

-Dan