[pacman-dev] [PATCH] makepkg: use basename instead of a sed command

Xavier shiningxc at gmail.com
Sat Oct 17 14:16:27 EDT 2009


On Sat, Oct 17, 2009 at 7:41 PM, Cedric Staniewski <cedric at gmx.ca> wrote:
> The basename command is easier to understand than a sed command and it
> is even slightly faster than sed.
>
> Signed-off-by: Cedric Staniewski <cedric at gmx.ca>
> ---
> or if you prefer bashisms, see next patch
>

I actually saw that code recently and thought exactly the same.
I prefer the bash way for code that is executed many times (for
performance reason), but it's not really the case here, so basename
should be fine.
Is basename available on all the os we support ?


More information about the pacman-dev mailing list