[pacman-dev] [PATCH] makepkg: only strip files that are writable

Xavier Chantry chantry.xavier at gmail.com
Tue Jan 26 12:56:22 EST 2010


On Tue, Jan 26, 2010 at 3:56 PM, Allan McRae <allan at archlinux.org> wrote:
>
> Ah, stupid incompatible implementations of core utilities...  So, changing
> that find to:
>
> find ${STRIP_DIRS[@]} -type f -perm -u+x
>
> should work everywhere.
>

A bunch of stupid questions :
- shouldn't it be rw rather than x ?
- why don't we just let strip handle that ? (i.e. let it fail if it
doesn't have the permission)
Also if makepkg and that command were run as root, the permissions
don't seem to matter
- would anyone want to strip everything regardless of their
permissions (and running strip as root for that reason) ?


More information about the pacman-dev mailing list