[arch-projects] [ABS] [PATCH 4/6] vcs prototypes: consistent coding style
Linus Arver
linusarver at gmail.com
Wed Nov 2 21:19:13 EDT 2011
On Wed, Nov 02, 2011 at 09:05:24PM -0400, Dave Reisner wrote:
> On Wed, Nov 02, 2011 at 05:52:20PM -0700, Linus Arver wrote:
> > Some vcs prototypes do something like
> >
> > cd repo && update
> >
> > while others do it like
> >
> > cd repo
> > update
> >
> > to update an existing repo. It makes sense to have them all do it the
> > second way, because the code is already inside an if block that checks
> > if the repo directory exists.
>
> Except that there's no reason not to go with the first form... cd'ing in
> a script without checking the result is bad form.
True... I'll just redo them all into the first form. I guess my coding
style is in bad form!
More information about the arch-projects
mailing list