[arch-projects] [mkinitcpio] [DRAFT] init: Remove last grep usage, but...

[Tom Gundersen]

On Tue, Nov 15, 2011 at 1:49 AM, Gerardo Exequiel Pozzi
<vmlinuz386 at yahoo.com.ar> wrote:
> The only downside is on systems where devtmpfs is not enabled
> will see and error message.
>
> Of course some shell code can be added to check /proc/filesystems,
> but should care about?

I think your patch is fine as it is. There is almost certainly no good
reason not to use devtmpfs, so this could serve as a friendly reminder
for people to look into it...


> ---
>  init |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/init b/init
> index c185375..25a51eb 100644
> --- a/init
> +++ b/init
> @@ -8,8 +8,7 @@ PATH=/usr/sbin:/usr/bin:/sbin:/bin
>
>  mount -t proc proc /proc -o nosuid,noexec,nodev
>  mount -t sysfs sys /sys -o nosuid,noexec,nodev
> -if grep -q devtmpfs /proc/filesystems; then
> -  mount -n -t devtmpfs udev /dev -o mode=0755,size=10M,nosuid
> +if mount -n -t devtmpfs udev /dev -o mode=0755,size=10M,nosuid; then
>   devtmpfs_mounted=1
>  else
>   mount -n -t tmpfs udev /dev -o mode=0755,size=10M,nosuid
> --
> 1.7.7.3
>
>