From xilonmu at gmail.com Tue Jan 1 02:53:21 2008 From: xilonmu at gmail.com (Sebastian) Date: Tue, 1 Jan 2008 16:53:21 +0900 Subject: [aur-dev] [AUR2] How to go about official dependencies In-Reply-To: <428d921d0712310858p397e2a77y86b21d0d4aa9d54a@mail.gmail.com> References: <428d921d0712310858p397e2a77y86b21d0d4aa9d54a@mail.gmail.com> Message-ID: > I don't think this is viable. > Remember, the AUR was (should continue to be) designed in such a way > that it could be run by someone not on the arch server. Direct > database access to the main arch repository would be a huge step in > the wrong direction for this, in my opinion. The database servers don't need to be on the same host in order to connect to them. It's possible to make use of the database without losing any modularity on AUR2's part. I was talking with Dan about "standardising" the main site and AUR, mainly in terms of Django models, because the two sites are so similar. AUR could easily simply be a Django app that the main site uses. It's a bit off-topic, but I don't think integrating the sites in some way (at least to be able to duplicate code easily) would be a bad move. > > Here's the schema for the package, category and repository relations, in > > case you'd like more insight into the database structure. As you will see > > it would be a little difficult to make a record with just the URL > > pointing to a search on the main site. > > {% for dep in pkg.deps %} > {{ dep }}
> {% endfor %} > > or whatever.. > > The main site search functionality returns the details page if there > is a single match. This isn't quite "optimal", as for packages like > vim, it will return a list. > > A better solution may be to add an additional search argument to the > search page, such that 'exact' matches are only attempted instead. eg > a seach on vim would only return details on the vim package itself, > instead of a list of packages with "vim" in the name. In order to do it that way we'd need to add another field like "official_deps" to the Packages relation. It would be a foreign key to an official_dependency relation holding only the name of the package (and possibly the url). Not a great solution, but possibly the quickest to implement. From eliott at cactuswax.net Tue Jan 1 05:00:13 2008 From: eliott at cactuswax.net (eliott) Date: Tue, 1 Jan 2008 02:00:13 -0800 Subject: [aur-dev] [AUR2] How to go about official dependencies In-Reply-To: References: <428d921d0712310858p397e2a77y86b21d0d4aa9d54a@mail.gmail.com> Message-ID: <428d921d0801010200p2297ded6l4510c7efb29f8548@mail.gmail.com> > The database servers don't need to be on the same host in order to > connect to them. It's possible to make use of the database without > losing any modularity on AUR2's part. Actually, it isn't. You *would* lose modularity, and you would have even tighter coupling. Additionally, remote sql invocation over arbitrary remote networks isn't the greatest idea from both a performance and a security standpoint. The goal of the AUR2 should not be tighter coupling. > I was talking with Dan about "standardising" the main site and AUR, > mainly in terms of Django models, because the two sites are so > similar. AUR could easily simply be a Django app that the main site > uses. It's a bit off-topic, but I don't think integrating the sites in > some way (at least to be able to duplicate code easily) would be a bad > move. With the rearchitecture of the main site, I don't think this is very feasible. I strongly feel that the AUR should remain "it's own app". From wizzomafizzo at gmail.com Wed Jan 2 15:53:50 2008 From: wizzomafizzo at gmail.com (Callan Barrett) Date: Thu, 3 Jan 2008 05:53:50 +0900 Subject: [aur-dev] [PATCH] Adds support for TUs and devs to disown packages they do not own Message-ID: <33f0f4ec0801021253w63ed465bn6873c0e366ba8726@mail.gmail.com> This is to add support for either devs or TUs to disown packages whether they own them or not. I know of countless times where I or another TU have been asked to orphan packages for someone and end up having to adopt the package first and then disown it, this gets really tedious for more than one package. As far as I can tell there's no other way to disown packages you don't own and if there is at least this is a more obvious way, pretty sure I didn't leave anything out in the patch. -- Callan 'wizzomafizzo' Barrett -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-Signed-off-by-Callan-Barrett-wizzomafizzo-gmail.co.patch Type: text/x-patch Size: 1646 bytes Desc: not available URL: From simo at archlinux.org Wed Jan 2 17:51:38 2008 From: simo at archlinux.org (Simo Leone) Date: Wed, 2 Jan 2008 16:51:38 -0600 Subject: [aur-dev] Roadmap Message-ID: <20080102225138.GA8486@neotuli.net> Hey guys, I would have written this email earlier, but I'm currently overseas enjoying the effects of global warming (since when does it not snow in the arctic?). I had a few spare minutes and decided it might be a good time to sit down and finally write the damn thing. Right, so I just wanted to get a few things cleared up about where I want to take the AUR, short and long term. In the short term, I'd like to keep things realistic. What can and can't we do with the current level of interest in the AUR? Big sweeping changes are out of the question, the userbase is quite large and the AUR is something very prominent in Archland. I haven't read an Arch review that doesn't mention the AUR in quite a while, so we must've got something right. We should be somewhat cautious about large public-facing changes and introducing regressions. Short term fast-track changes should be things like bugfixes, and admin-side changes, and small no-brainer type stuff. Keeping with that, I'd like to tweak the interface a bit. It's always struck me as a tad clunky, and could use some refinement. Parts of it are buggy too. Another small welcome change would be fixing those nasty URLs. Changes here should be backward-compatible, since AUR links are likely pasted in all sorts of places. The AUR's long-term future is less certain. One thing I'd like to get cleared up is this stuff about AUR2. First off, I'd like to know how many separate people/groups are currently coding some AUR-successor. I admit that I probably made a mistake in even introducing the idea of recoding the AUR, and after some further thought it's probably in our best interests to improve upon what we have, and be satisfied with it before any kind of recode is seriously considered. If you're currently working on a 'new' AUR, now's a good time to speak up, so your hard work doesn't go to waste. That said, I've always felt that the AUR's codebase is on a pretty shaky foundation, and needs some serious rearranging. One of my biggest long-term goals is to functionalize the code, and separate the HTML from underlying logic, particularly SQL queries! As it stands, most of it looks like HTML/SQL/PHP soup, a lot of it quite repetative. This is really bad programming practice for a whole shizload of reasons, security among them. Another long-term issue is cleaning up the data. A lot of the users are dead, and packages uncared for. The idea of package maintenence/ownership might be interesting to reexamine and rethink at some point, the results might really benefit the community. There is a whole whole lot more that belongs on both lists, but taking it slow, steady, and simple, is best. The AUR is still growing and maturing as a project, let's not try to make it grow up overnight. Lastly, I welcome you to send patches and take advantage of aur-dev. Developing is always more rewarding when you have others to put their momentum in the same direction. -- Simo Leone Arch Linux Developer -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available URL: From tardo at nagi-fanboi.net Wed Jan 2 23:39:42 2008 From: tardo at nagi-fanboi.net (tardo) Date: Wed, 2 Jan 2008 23:39:42 -0500 (EST) Subject: [aur-dev] Roadmap In-Reply-To: <20080102225138.GA8486@neotuli.net> References: <20080102225138.GA8486@neotuli.net> Message-ID: <61494.68.159.102.112.1199335182.squirrel@webmail.nagi-fanboi.net> Simo Leone ????????? > Hey guys, > > I would have written this email earlier, but I'm currently overseas > enjoying the effects of global warming (since when does it not snow in > the arctic?). I had a few spare minutes and decided it might be a good > time to sit down and finally write the damn thing. > > Right, so I just wanted to get a few things cleared up about where I > want to take the AUR, short and long term. > > In the short term, I'd like to keep things realistic. What can and can't > we do with the current level of interest in the AUR? Big sweeping > changes are out of the question, the userbase is quite large and the AUR > is something very prominent in Archland. I haven't read an Arch review > that doesn't mention the AUR in quite a while, so we must've got > something right. We should be somewhat cautious about large > public-facing changes and introducing regressions. Short term fast-track > changes should be things like bugfixes, and admin-side changes, and > small no-brainer type stuff. > Keeping with that, I'd like to tweak the interface a > bit. It's always struck me as a tad clunky, and could use some > refinement. Parts of it are buggy too. > Another small welcome change would be fixing those nasty URLs. Changes > here should be backward-compatible, since AUR links are likely pasted > in all sorts of places. > > The AUR's long-term future is less certain. One thing I'd like to get > cleared up is this stuff about AUR2. First off, I'd like to know how > many separate people/groups are currently coding some AUR-successor. > I admit that I probably made a mistake in even introducing the idea > of recoding the AUR, and after some further thought it's probably in > our best interests to improve upon what we have, and be satisfied > with it before any kind of recode is seriously considered. If you're > currently working on a 'new' AUR, now's a good time to speak up, so your > hard work doesn't go to waste. > That said, I've always felt that the AUR's codebase is on a pretty > shaky foundation, and needs some serious rearranging. One of my biggest > long-term goals is to functionalize the code, and separate the HTML from > underlying logic, particularly SQL queries! As it stands, most of it > looks like HTML/SQL/PHP soup, a lot of it quite repetative. This is > really bad programming practice for a whole shizload of reasons, > security among them. > Another long-term issue is cleaning up the data. A lot of the users > are dead, and packages uncared for. The idea of package > maintenence/ownership might be interesting to reexamine and rethink at > some point, the results might really benefit the community. > > There is a whole whole lot more that belongs on both lists, but taking > it slow, steady, and simple, is best. The AUR is still growing and > maturing as a project, let's not try to make it grow up overnight. > Lastly, I welcome you to send patches and take advantage of aur-dev. > Developing is always more rewarding when you have others to put their > momentum in the same direction. > > -- > Simo Leone > Arch Linux Developer > Take a look here: http://git.nagi-fanboi.net/?p=aur.git;a=summary Some of what you ask has already been done by myself and Loui. Feel free to grab parts of code you think is useful. I can't suggest merging the branch because this was based off a previous version of the AUR. I'd love to help rebase/rework the code, but I lose internet in two days and won't be online for about a month (until I find an apartment). - tardo From louipc.ist at gmail.com Thu Jan 3 00:34:50 2008 From: louipc.ist at gmail.com (Loui) Date: Thu, 3 Jan 2008 00:34:50 -0500 Subject: [aur-dev] Roadmap In-Reply-To: <20080102225138.GA8486@neotuli.net> References: <20080102225138.GA8486@neotuli.net> Message-ID: <50673e970801022134h3c243fc2k82c45ffd734f1b6a@mail.gmail.com> On Jan 2, 2008 5:51 PM, Simo Leone wrote: > I admit that I probably made a mistake in even introducing the idea > of recoding the AUR. I think introducing the idea was the best thing to do! After two months of trying to fiddle with the current AUR code I realised that it really isn't worth fixing. I assumed that development slowed because the devs came to that realisation. I think the development manpower would be much better spent working on a completely new system, especially since we've given the interface a bit of a facelift. The only dev on current code I could see making sense are critical bug fixes. I see the next generation of AUR as a network app primarily accessible via CLI tools, but also accessible via other interfaces (web,gtk, etc). I have some other crazy ideas, that might be out of topic for now. Ha! > Another long-term issue is cleaning up the data. A lot of the users > are dead, and packages uncared for. This is another great reason to start fresh. I say toss the old DB once the new system is ready. From xilonmu at gmail.com Thu Jan 3 00:44:29 2008 From: xilonmu at gmail.com (Sebastian) Date: Thu, 3 Jan 2008 14:44:29 +0900 Subject: [aur-dev] Roadmap In-Reply-To: <50673e970801022134h3c243fc2k82c45ffd734f1b6a@mail.gmail.com> References: <20080102225138.GA8486@neotuli.net> <50673e970801022134h3c243fc2k82c45ffd734f1b6a@mail.gmail.com> Message-ID: Afaik there are two AUR2 projects. The first one was the "br" [1] one that was started ages ago, but the developers are very quite and it's hard to get a hold of them. I tried to make them more active in terms of communication but it seems I failed. I spoke with one of the developers and he said they were very close to finishing but I haven't seen any of them since then. Having looked at the code it seems they simply tried to replicate the current AUR in Django so there probably weren't many advantages over the current AUR besides cleaner code. There's also the newer project [2] which seems to be developed only be me now, but Thralas was also active at the beginning. It's getting close to replicating the functionality of the current AUR, but there's still lots to be done.When designing it we aimed for it to be more flexible and generally just more thought out than the current AUR. I'm not a TU or developer so it's a bit hard for me to think of ways to improve the interface for TUs, especially since the cvs system and web interface seems to be only linked by the database. There might be some more information on the wiki; http://wiki.archlinux.org/index.php/AUR_2 The current AUR requires a total rewrite either way, so I don't think there's any point investing much time in adding any features to it. One of the biggest issues (afaik, since I haven't looked at the db schema) is the mixing of business logic and presentation. It's really aweful to try and hack the code when it's like that. The Django framework, as most of you probably know, is really easy to use and fast to develop with, so I think it would be a better investment to focus on any of the new projects. [1] http://aur2.archlinux-br.org/ [2] http://repo.or.cz/w/aur2-xilon.git From wizzomafizzo at gmail.com Thu Jan 3 11:27:17 2008 From: wizzomafizzo at gmail.com (Callan Barrett) Date: Fri, 4 Jan 2008 01:27:17 +0900 Subject: [aur-dev] [PATCH] Removes timeout page and moves login form to header Message-ID: <33f0f4ec0801030827j5a35cddao18316c18ec418c29@mail.gmail.com> This removes the need for a timeout page (and probably hacker.php) and moves the login form and status to the header. If your login times out you won't lose your place anymore and links will always work. Works for me but at the moment index_po.php is imported in aur.inc which has to stay until the translations from it for login are moved to aur_po.php. -- Callan 'wizzomafizzo' Barrett -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-Signed-off-by-Callan-Barrett-wizzomafizzo-gmail.co.patch Type: text/x-patch Size: 8471 bytes Desc: not available URL: From aaronmgriffin at gmail.com Thu Jan 3 12:27:59 2008 From: aaronmgriffin at gmail.com (Aaron Griffin) Date: Thu, 3 Jan 2008 11:27:59 -0600 Subject: [aur-dev] [PATCH] Removes timeout page and moves login form to header In-Reply-To: <33f0f4ec0801030827j5a35cddao18316c18ec418c29@mail.gmail.com> References: <33f0f4ec0801030827j5a35cddao18316c18ec418c29@mail.gmail.com> Message-ID: On Jan 3, 2008 10:27 AM, Callan Barrett wrote: > This removes the need for a timeout page I love you From aaronmgriffin at gmail.com Thu Jan 3 12:30:08 2008 From: aaronmgriffin at gmail.com (Aaron Griffin) Date: Thu, 3 Jan 2008 11:30:08 -0600 Subject: [aur-dev] [PATCH] Removes timeout page and moves login form to header In-Reply-To: <33f0f4ec0801030827j5a35cddao18316c18ec418c29@mail.gmail.com> References: <33f0f4ec0801030827j5a35cddao18316c18ec418c29@mail.gmail.com> Message-ID: On Jan 3, 2008 10:27 AM, Callan Barrett wrote: > This removes the need for a timeout page (and probably hacker.php) and > moves the login form and status to the header. If your login times out > you won't lose your place anymore and links will always work. Works > for me but at the moment index_po.php is imported in aur.inc which has > to stay until the translations from it for login are moved to > aur_po.php. Quick comment. All the git tools expect the following commit message format: >>>>> [One line description] [Body description with long text and sign-off lines] <<<<< This is why your patch shows "Signed off by..." as the filename/title of the patch. From wizzomafizzo at gmail.com Thu Jan 3 12:40:52 2008 From: wizzomafizzo at gmail.com (Callan Barrett) Date: Fri, 4 Jan 2008 02:40:52 +0900 Subject: [aur-dev] [PATCH] Removes timeout page and moves login form to header In-Reply-To: References: <33f0f4ec0801030827j5a35cddao18316c18ec418c29@mail.gmail.com> Message-ID: <33f0f4ec0801030940v56007288q19e06553cfabcfec@mail.gmail.com> On Jan 4, 2008 2:30 AM, Aaron Griffin wrote: > > Quick comment. > > All the git tools expect the following commit message format: > >>>>> > [One line description] > > [Body description with long text and sign-off lines] > <<<<< > > This is why your patch shows "Signed off by..." as the filename/title > of the patch. Oh right, gotta remember that next time. Thanks. -- Callan 'wizzomafizzo' Barrett From eliott at cactuswax.net Thu Jan 3 15:32:45 2008 From: eliott at cactuswax.net (eliott) Date: Thu, 3 Jan 2008 12:32:45 -0800 Subject: [aur-dev] [PATCH] Removes timeout page and moves login form to header In-Reply-To: <33f0f4ec0801030827j5a35cddao18316c18ec418c29@mail.gmail.com> References: <33f0f4ec0801030827j5a35cddao18316c18ec418c29@mail.gmail.com> Message-ID: <428d921d0801031232wc6f0672n4d5fb9b0f2d54c8c@mail.gmail.com> On 1/3/08, Callan Barrett wrote: > This removes the need for a timeout page (and probably hacker.php) and > moves the login form and status to the header. If your login times out > you won't lose your place anymore and links will always work. Works > for me but at the moment index_po.php is imported in aur.inc which has > to stay until the translations from it for login are moved to > aur_po.php. > > -- > Callan 'wizzomafizzo' Barrett Applied to my testing branch. I would like to mirror Aaron's sentiments. Maybe...without the uncomfortably long hug though.. ;) From wizzomafizzo at gmail.com Thu Jan 3 16:26:47 2008 From: wizzomafizzo at gmail.com (Callan Barrett) Date: Fri, 4 Jan 2008 06:26:47 +0900 Subject: [aur-dev] [PATCH] Fix bug with botched AURSID values Message-ID: <33f0f4ec0801031326v21ce8302tbe54b3e11fffc559@mail.gmail.com> In the check_sid function in aur.inc the condition for expiring the cookie and redirecting to hacker.php could never be met and instead the user would be given blank login instead of being considered logged out, now fixed. This also means we no longer need either hacker.php or timeout.php at all. Also, this bug seems to be present in the AUR version running on aur.archlinux.org. -- Callan 'wizzomafizzo' Barrett -------------- next part -------------- A non-text attachment was scrubbed... Name: 0002-Fix-bug-with-botched-AURSID-values.patch Type: text/x-patch Size: 2577 bytes Desc: not available URL: From louipc.ist at gmail.com Thu Jan 3 18:24:17 2008 From: louipc.ist at gmail.com (Loui) Date: Thu, 3 Jan 2008 18:24:17 -0500 Subject: [aur-dev] [PATCH] Removes timeout page and moves login form to header In-Reply-To: <428d921d0801031232wc6f0672n4d5fb9b0f2d54c8c@mail.gmail.com> References: <33f0f4ec0801030827j5a35cddao18316c18ec418c29@mail.gmail.com> <428d921d0801031232wc6f0672n4d5fb9b0f2d54c8c@mail.gmail.com> Message-ID: <50673e970801031524q50233b2bj93153524873e6d39@mail.gmail.com> Hey Callan. I guess you're working off of the testing branch? Please have a look at web/template/login_form.php :D I put down the mechanics but I didn't actually put it into use. I couldn't be sure if a log in form on every page is necessary. Maybe you only really need a login form when you need to log in, like if you want to post a comment. From wizzomafizzo at gmail.com Thu Jan 3 19:22:59 2008 From: wizzomafizzo at gmail.com (Callan Barrett) Date: Fri, 4 Jan 2008 09:22:59 +0900 Subject: [aur-dev] [PATCH] Removes timeout page and moves login form to header In-Reply-To: <50673e970801031524q50233b2bj93153524873e6d39@mail.gmail.com> References: <33f0f4ec0801030827j5a35cddao18316c18ec418c29@mail.gmail.com> <428d921d0801031232wc6f0672n4d5fb9b0f2d54c8c@mail.gmail.com> <50673e970801031524q50233b2bj93153524873e6d39@mail.gmail.com> Message-ID: <33f0f4ec0801031622l5a31162fvce6b2068b23cdb5b@mail.gmail.com> On Jan 4, 2008 8:24 AM, Loui wrote: > Hey Callan. I guess you're working off of the testing branch? Please > have a look at web/template/login_form.php :D > I put down the mechanics but I didn't actually put it into use. I > couldn't be sure if a log in form on every page is necessary. > Maybe you only really need a login form when you need to log in, like > if you want to post a comment. Hello Loui, I am working off the testing branch, didn't notice the login form template though. I'll take a look at it and I think it's an alright idea to split this up into two files but I don't really agree with only having the login form on just a few pages, I think it should still stay in the header (or in its own function called on every page, but html_header already does that and it would mean changing most of the code related). I'll give an example, if I'm given a url to package details page that I need to delete or orphan but I've been logged out it would be way more convenient if I could log back in using that page, not a whole lot to disrupt the work flow. This isn't really uncommon and can be applied basically anywhere on the AUR because let's face it, there's really only about 5 "pages" on the AUR and at least as a TU they all need to be used logged in. A good example of how convenient this is is on the bug tracker and I doubt that takes any extra resources. -- Callan 'wizzomafizzo' Barrett From shezq23 at gmail.com Fri Jan 4 00:07:07 2008 From: shezq23 at gmail.com (Shehzad Qureshi) Date: Fri, 4 Jan 2008 00:07:07 -0500 Subject: [aur-dev] Roadmap In-Reply-To: <61494.68.159.102.112.1199335182.squirrel@webmail.nagi-fanboi.net> References: <20080102225138.GA8486@neotuli.net> <61494.68.159.102.112.1199335182.squirrel@webmail.nagi-fanboi.net> Message-ID: <222254590801032107nae3023te61318800c8d874d@mail.gmail.com> I forgot to add... here's a demo of what that git tree looks like: http://aur.nagi-fanboi.net/ -------------- next part -------------- An HTML attachment was scrubbed... URL: From wizzomafizzo at gmail.com Fri Jan 4 05:53:58 2008 From: wizzomafizzo at gmail.com (Callan Barrett) Date: Fri, 4 Jan 2008 19:53:58 +0900 Subject: [aur-dev] Roadmap In-Reply-To: <222254590801032107nae3023te61318800c8d874d@mail.gmail.com> References: <20080102225138.GA8486@neotuli.net> <61494.68.159.102.112.1199335182.squirrel@webmail.nagi-fanboi.net> <222254590801032107nae3023te61318800c8d874d@mail.gmail.com> Message-ID: <33f0f4ec0801040253x7b91963av1f5111cf34387ce8@mail.gmail.com> On Jan 4, 2008 2:07 PM, Shehzad Qureshi wrote: > I forgot to add... here's a demo of what that git tree looks like: > > http://aur.nagi-fanboi.net/ I think this looks great! Some of the little things you've put in really add to usability. I really like the stuff such as the search form in the header (or you know, on every page), the way logging out is just a form on the current page and how you got rid of the useless get variables. Love to see most of this in cactus' repo. :) -- Callan 'wizzomafizzo' Barrett From xilonmu at gmail.com Fri Jan 4 10:21:07 2008 From: xilonmu at gmail.com (Sebastian Nowicki) Date: Sat, 5 Jan 2008 00:21:07 +0900 Subject: [aur-dev] AUR2 Screenshots In-Reply-To: <20080102225138.GA8486@neotuli.net> References: <20080102225138.GA8486@neotuli.net> Message-ID: <20080104151458.GA27602@Odin> I thought it might be a good idea to give more insight to people who can't setup django or simply don't want to. The following screenshots were taken from the current (as of 04.01.2007) snapshot of my repository. Package listing/Main page: - http://img184.imageshack.us/img184/9740/200801042315061679x527skz6.png When searching, if there's only one hit it goes straight to that package's page. Upload form: - http://img301.imageshack.us/img301/4172/200801042317511679x588sod7.png Trying to upload an invalid package: - http://img177.imageshack.us/img177/4753/200801042318021679x787sbt3.png It also checks that at least one set of checksums exist. The parser is based on namcap's parsepkgbuild, except it outputs information in a different format (python). Package details of the newly uploaded package: - http://img112.imageshack.us/img112/5418/200801042319181665x1016pl8.png None of the files (PKGBUILD, tarball, sources) are saved to disk yet, since we're still working out how to go about it. Dependencies from the official repos don't get recorded either, since there's no access to the main DB and some alterations to the AUR DB would be required[1]. Account page: - http://img184.imageshack.us/img184/5589/200801050002271679x612sqz5.png After logging in directly (clicking on the login link), the user is redirected to this page. Account page (new user): - http://img521.imageshack.us/img521/2258/200801050006141679x609sam8.png The PKGBUILD link directs to the user to the AUR User Guidelines[2] and the "these requests" link directs the user to the requests forum[3]. These links are hardcoded in the template. Login form (with errors): - http://img131.imageshack.us/img131/7356/200801042348081679x505slp3.png Registration form: - http://img137.imageshack.us/img137/5193/200801050004291679x529swp2.png Package listing (logged out): - http://img155.imageshack.us/img155/3650/200801042328321679x546soh9.png I think that covers it. Suggestions/flaming is, of course, welcome. [1] http://archlinux.org/pipermail/aur-dev/2008-January/000021.html [2] http://wiki.archlinux.org/index.php/Arch_Packaging_Standards [3] http://bbs.archlinux.org/viewforum.php?id=38 From aaronmgriffin at gmail.com Fri Jan 4 12:17:30 2008 From: aaronmgriffin at gmail.com (Aaron Griffin) Date: Fri, 4 Jan 2008 11:17:30 -0600 Subject: [aur-dev] AUR2 Screenshots In-Reply-To: <20080104151458.GA27602@Odin> References: <20080102225138.GA8486@neotuli.net> <20080104151458.GA27602@Odin> Message-ID: Oooh, purty From wizzomafizzo at gmail.com Sat Jan 5 09:05:22 2008 From: wizzomafizzo at gmail.com (Callan Barrett) Date: Sat, 5 Jan 2008 23:05:22 +0900 Subject: [aur-dev] AUR Variable Names Message-ID: <33f0f4ec0801050605x762268f9xb7d3cc1c34e688c7@mail.gmail.com> I'd like some suggestions on how we deal with the issue of this: http://aur.archlinux.org/packages.php?do_Details=1&ID=6978&O=0&L=&C=&K=&SB=&SO=&PP=&do_MyPackages=&do_Orphans=&SeB= I've seen suggestions of mod_rewrite but really nothing further, I'll start us off but I really want opinions from at least a few different people. To begin I'm not really thrilled with the idea of mod_rewrite at all and I can't find much of a point to using it, I've been told it will be amazing because then we can have urls like /search/foo/ but so what? People don't search using urls they search with the search form and the fact we can start going /package/1337/ instead of say packages.php?id=1337 is so incredibly minor why should we bother? I propose that at the very least (that is even if we decide to use mod_rewrite for some crazy reason) we change the variable names to something that's actually descriptive and try get rid of as many variables as possible. If you take a look at tardo's repo you can see the details page now only requires the package id variable and nothing else which is a great step in the right direction, we can also get rid of the sorting options in the search form because you can already sort via the links in column names and the variables do_Search is just as pointless as do_Details. With just these changes we get something like O=0&L=&C=&K=&PP=&SeB= which we could probably make even smaller and nicer if we changed variable names to be descriptive. Anyway, most of all I want to hear what other people have to say about this because I think choosing the right names and issues like backwards compatibility are pretty important. -- Callan 'wizzomafizzo' Barrett From louipc.ist at gmail.com Sat Jan 5 12:16:33 2008 From: louipc.ist at gmail.com (Loui) Date: Sat, 5 Jan 2008 12:16:33 -0500 Subject: [aur-dev] AUR Variable Names In-Reply-To: <33f0f4ec0801050605x762268f9xb7d3cc1c34e688c7@mail.gmail.com> References: <33f0f4ec0801050605x762268f9xb7d3cc1c34e688c7@mail.gmail.com> Message-ID: <50673e970801050916s9f534dan1974c0f217231979@mail.gmail.com> First of all look at how many of those variables are empty. Make the code not put empty variables into the URL and make the code that gets the variables deal with unset/empty variables. I was working on this at some point. 1. On the search page you could use a function for processing variables when sorting results in various ways (eg. by name, maintainer, repo, etc) There's a lot of repeated code there... I'm not sure if I committed any change there 2. For details page I was thinking of storing search parameters into a cookie so you could still go back to the search page to resume looking at previous search results. 3. Separate package search code from package details code. (If it hasn't already been done) $do_Details doesn't actually mean anything. I could set do_Details=gramma and it'll still show me the pkg details, the only requirement seems to be that it is set. so make packages.php only show details and get rid of that variable. It won't hurt existing URL links if you get rid of it either. Make another page like search_packages.php for searching packages. You might want to bug people to get those previous patches applied before getting too ahead hehe. Cheers. On Jan 5, 2008 9:05 AM, Callan Barrett wrote: > I'd like some suggestions on how we deal with the issue of this: > http://aur.archlinux.org/packages.php?do_Details=1&ID=6978&O=0&L=&C=&K=&SB=&SO=&PP=&do_MyPackages=&do_Orphans=&SeB= > > I've seen suggestions of mod_rewrite but really nothing further, I'll > start us off but I really want opinions from at least a few different > people. To begin I'm not really thrilled with the idea of mod_rewrite > at all and I can't find much of a point to using it, I've been told it > will be amazing because then we can have urls like /search/foo/ but so > what? People don't search using urls they search with the search form > and the fact we can start going /package/1337/ instead of say > packages.php?id=1337 is so incredibly minor why should we bother? > > I propose that at the very least (that is even if we decide to use > mod_rewrite for some crazy reason) we change the variable names to > something that's actually descriptive and try get rid of as many > variables as possible. If you take a look at tardo's repo you can see > the details page now only requires the package id variable and nothing > else which is a great step in the right direction, we can also get rid > of the sorting options in the search form because you can already sort > via the links in column names and the variables do_Search is just as > pointless as do_Details. With just these changes we get something like > O=0&L=&C=&K=&PP=&SeB= which we could probably make even smaller and > nicer if we changed variable names to be descriptive. > > Anyway, most of all I want to hear what other people have to say about > this because I think choosing the right names and issues like > backwards compatibility are pretty important. > > -- > Callan 'wizzomafizzo' Barrett > > From xilonmu at gmail.com Sat Jan 5 12:56:29 2008 From: xilonmu at gmail.com (Sebastian Nowicki) Date: Sun, 6 Jan 2008 02:56:29 +0900 Subject: [aur-dev] AUR2 directory structure Message-ID: <20080105173206.GA7927@Odin> I'd like to implement saving files to disk, but to do so I first need to decide on the directory structure. Django's FileField model field wants to upload files relative to MEDIA_ROOT[1]. Since I'm currently using the main site's CSS and images directly, MEDIA_ROOT hasn't been used yet. To simplify the problem I think it's best to simply ignore the fact that there may be an SCM backend. We should just focus on the relative directory structure. The easy way to go would be dumping everything into MEDIA_ROOT/repository/package_name/ (possible using MEDIA_ROOT/packages/...). It's simple and easy to navigate. The directory would hold the PKGBUILD, and source or install files and the tarball. The files would be accessible via MEDIA_URL/[packages/]repository/package_name/, with packages/ being optional. I'm not sure that using MEDIA_ROOT is a good idea since, if we eventually get some, images and CSS files, etc. would also go into it, so it seems a bit odd. Also if we do choose to go with an SCM like subversion then it would most likely have to be separated from the MEDIA_ROOT. I'm not sure if overloading this behaviour of the FileField is possible, so we may simply need to use a CharField and do anything, that FileField does for us, manually. For those familiar with the current AUR code, how does AUR do it? Does it even store the source file separately? And how does the main site handle it? [1] http://www.djangoproject.com/documentation/model-api/#filefield From xilonmu at gmail.com Sat Jan 5 13:06:00 2008 From: xilonmu at gmail.com (Sebastian Nowicki) Date: Sun, 6 Jan 2008 03:06:00 +0900 Subject: [aur-dev] AUR Variable Names In-Reply-To: <50673e970801050916s9f534dan1974c0f217231979@mail.gmail.com> References: <33f0f4ec0801050605x762268f9xb7d3cc1c34e688c7@mail.gmail.com> <50673e970801050916s9f534dan1974c0f217231979@mail.gmail.com> Message-ID: <20080105180600.GB7927@Odin> On Sat, Jan 05, 2008 at 12:16:33PM -0500, Loui wrote: > First of all look at how many of those variables are empty. Make the > code not put empty variables into the URL and make the code that gets > the variables deal with unset/empty variables. I was working on this > at some point. I don't think this is possible. The code has nothing to do with what the browser sends to the server. The way it works is that the browser requests the search page from the server. The PHP script does it's thing and outputs the HTML page, which gets downloaded and displayed to the user. The user inputs whatever keywords the user wants and submits. The _browser_ then parses the form and sends the appropriate GET/POST headers (and content). Since some fields are empty (I assume this is why empty variables show up) the browser sends these empty variables in the GET request. The only solution to this that I see is by using JavaScript to dynamically remove any empty fields from the form on an onSubmit event, though I'm not sure that this would actually work. From louipc.ist at gmail.com Sat Jan 5 13:15:30 2008 From: louipc.ist at gmail.com (Loui) Date: Sat, 5 Jan 2008 13:15:30 -0500 Subject: [aur-dev] AUR Variable Names In-Reply-To: <20080105180600.GB7927@Odin> References: <33f0f4ec0801050605x762268f9xb7d3cc1c34e688c7@mail.gmail.com> <50673e970801050916s9f534dan1974c0f217231979@mail.gmail.com> <20080105180600.GB7927@Odin> Message-ID: <50673e970801051015o30048538ld27883eb977dc224@mail.gmail.com> I'm saying deal with it in the current AUR code. Of course it's possible. There's nothing you can do about outside links other than make sure that the code can deal with that properly. You'd have to do that anyways if you want to omit variables and let them default to something if they're unset. On Jan 5, 2008 1:06 PM, Sebastian Nowicki wrote: > On Sat, Jan 05, 2008 at 12:16:33PM -0500, Loui wrote: > > First of all look at how many of those variables are empty. Make the > > code not put empty variables into the URL and make the code that gets > > the variables deal with unset/empty variables. I was working on this > > at some point. > > I don't think this is possible. The code has nothing to do with what the > browser sends to the server. The way it works is that the browser > requests the search page from the server. The PHP script does it's thing > and outputs the HTML page, which gets downloaded and displayed to the > user. The user inputs whatever keywords the user wants and submits. The > _browser_ then parses the form and sends the appropriate GET/POST > headers (and content). Since some fields are empty (I assume this is why > empty variables show up) the browser sends these empty variables in the > GET request. > > The only solution to this that I see is by using JavaScript to > dynamically remove any empty fields from the form on an onSubmit event, > though I'm not sure that this would actually work. > > From eliott at cactuswax.net Sat Jan 5 14:24:29 2008 From: eliott at cactuswax.net (eliott) Date: Sat, 5 Jan 2008 11:24:29 -0800 Subject: [aur-dev] AUR Variable Names In-Reply-To: <33f0f4ec0801050605x762268f9xb7d3cc1c34e688c7@mail.gmail.com> References: <33f0f4ec0801050605x762268f9xb7d3cc1c34e688c7@mail.gmail.com> Message-ID: <428d921d0801051124n48907ebt662b84ac698d9645@mail.gmail.com> On 1/5/08, Callan Barrett wrote: > I'd like some suggestions on how we deal with the issue of this: > http://aur.archlinux.org/packages.php?do_Details=1&ID=6978&O=0&L=&C=& > K=&SB=&SO=&PP=&do_MyPackages=&do_Orphans=&SeB= > > I've seen suggestions of mod_rewrite but really nothing further, I'll > start us off but I really want opinions from at least a few different > people. To begin I'm not really thrilled with the idea of mod_rewrite > at all and I can't find much of a point to using it, I've been told it > will be amazing because then we can have urls like /search/foo/ but so > what? People don't search using urls they search with the search form > and the fact we can start going /package/1337/ instead of say > packages.php?id=1337 is so incredibly minor why should we bother? > > I propose that at the very least (that is even if we decide to use > mod_rewrite for some crazy reason) we change the variable names to > something that's actually descriptive and try get rid of as many > variables as possible. If you take a look at tardo's repo you can see > the details page now only requires the package id variable and nothing > else which is a great step in the right direction, we can also get rid > of the sorting options in the search form because you can already sort > via the links in column names and the variables do_Search is just as > pointless as do_Details. With just these changes we get something like > O=0&L=&C=&K=&PP=&SeB= which we could probably make even smaller and > nicer if we changed variable names to be descriptive. > > Anyway, most of all I want to hear what other people have to say about > this because I think choosing the right names and issues like > backwards compatibility are pretty important. I recommend something similar to what Loui said. Split packages.php into separate files, such as search.php and details.php. Then the long ugly url goes away in the search result package links (just a ?pkgid=100 or whatever). The search page will still have a marginally ugly url when you click a column to sort, but that can certainly be reduced. As to reasoning behind 'pretty urls', they are generally used for two reasons: 1. Search engine results 2. Human readability Search engines give a higher page rank to urls that are descriptive regarding the page. So /packages/exaile would have a higher rank than /packages.php?pkgname=exaile. They may disregard get args, but I don't know. As for #2, that one is obvious. If someone types a url in by hand, they may have a chance at going right to the page they want. I don't know if we care about #1, and #2 may be a non issue in our case...because people are using the system just fine now. From wizzomafizzo at gmail.com Sat Jan 5 16:05:39 2008 From: wizzomafizzo at gmail.com (Callan Barrett) Date: Sun, 6 Jan 2008 06:05:39 +0900 Subject: [aur-dev] AUR Variable Names In-Reply-To: <428d921d0801051124n48907ebt662b84ac698d9645@mail.gmail.com> References: <33f0f4ec0801050605x762268f9xb7d3cc1c34e688c7@mail.gmail.com> <428d921d0801051124n48907ebt662b84ac698d9645@mail.gmail.com> Message-ID: <33f0f4ec0801051305p7ee7f204q98661ec9856f43e6@mail.gmail.com> On Jan 6, 2008 4:24 AM, eliott wrote: > I recommend something similar to what Loui said. > Split packages.php into separate files, such as search.php and details.php. > Then the long ugly url goes away in the search result package links > (just a ?pkgid=100 or whatever). > > The search page will still have a marginally ugly url when you click a > column to sort, but that can certainly be reduced. The only reason the result links are so long is because there is a link on the details page for "going back to search results" which we can probably achieve the same result by getting rid of the link and providing information about the browser's back button. If we do that this problem is solved and ?pkgid=100 is all we need in this case, too (not saying splitting packages.php is a bad idea, just that we don't *need* to do it to achieve this). I think top priority is fixing how much stuff the search form has to submit, it's a pretty big form for what it does and who knows why it still uses the post method. Also I guess making the AUR use mod_rewrite is pretty minimal to do so we could easily do it on top of changing the normal variable names. Loui: Yes, we could use a function to make the urls based on what we actually have but that is sort of minor compared to actually changing the names to something readable, they're not just ugly because they're long they're ugly because they make absolutely no sense. What patches exactly are you referring to? -- Callan 'wizzomafizzo' Barrett From tardo at nagi-fanboi.net Sat Jan 5 21:19:55 2008 From: tardo at nagi-fanboi.net (tardo) Date: Sat, 5 Jan 2008 21:19:55 -0500 Subject: [aur-dev] AUR Variable Names In-Reply-To: <33f0f4ec0801051305p7ee7f204q98661ec9856f43e6@mail.gmail.com> References: <33f0f4ec0801050605x762268f9xb7d3cc1c34e688c7@mail.gmail.com> <428d921d0801051124n48907ebt662b84ac698d9645@mail.gmail.com> <33f0f4ec0801051305p7ee7f204q98661ec9856f43e6@mail.gmail.com> Message-ID: <222254590801051819y28f726bft8e9e7f59e4f984c@mail.gmail.com> lol... look in my git repo, i've already done all of the above (with the exception of empty vars and seo). -------------- next part -------------- An HTML attachment was scrubbed... URL: From wizzomafizzo at gmail.com Sat Jan 5 21:55:10 2008 From: wizzomafizzo at gmail.com (Callan Barrett) Date: Sun, 6 Jan 2008 11:55:10 +0900 Subject: [aur-dev] AUR Variable Names In-Reply-To: <222254590801051819y28f726bft8e9e7f59e4f984c@mail.gmail.com> References: <33f0f4ec0801050605x762268f9xb7d3cc1c34e688c7@mail.gmail.com> <428d921d0801051124n48907ebt662b84ac698d9645@mail.gmail.com> <33f0f4ec0801051305p7ee7f204q98661ec9856f43e6@mail.gmail.com> <222254590801051819y28f726bft8e9e7f59e4f984c@mail.gmail.com> Message-ID: <33f0f4ec0801051855l66945070o7dcd7e8343122629@mail.gmail.com> On Jan 6, 2008 11:19 AM, tardo wrote: > lol... look in my git repo, i've already done all of the above (with the > exception of empty vars and seo). I know, I wrote exactly what you just typed in the original email. -- Callan 'wizzomafizzo' Barrett From wizzomafizzo at gmail.com Sun Jan 6 19:46:47 2008 From: wizzomafizzo at gmail.com (Callan Barrett) Date: Mon, 7 Jan 2008 09:46:47 +0900 Subject: [aur-dev] [PATCH] Add notify column in search results and notify button Message-ID: <33f0f4ec0801061646kd41a25dvea6ad5b4f2ddde78@mail.gmail.com> Lets you toggle notification for many packages at once and tells of their status from the search results (like the voted column). Works for me. -- Callan 'wizzomafizzo' Barrett -------------- next part -------------- A non-text attachment was scrubbed... Name: 0003-Add-notify-column-in-search-results-and-notify-butto.patch Type: text/x-patch Size: 9195 bytes Desc: not available URL: From xilonmu at gmail.com Mon Jan 7 07:04:07 2008 From: xilonmu at gmail.com (Sebastian Nowicki) Date: Mon, 7 Jan 2008 21:04:07 +0900 Subject: [aur-dev] AUR2 directory structure In-Reply-To: <20080105173206.GA7927@Odin> References: <20080105173206.GA7927@Odin> Message-ID: <20080107120407.GA7370@Odin> Since there were no replies I just went ahead and implemented one I thought was the most logical. Sources, along with the PKGBUILD/tarball are now saved to the filesystem and properly recorded. I still need to implement downloading the tarball properly. At the moment it just gets the file off the file system, but in order to count the number of downloads I'd need to make it go through a view. Here's a sample directory listing: media/packages |-- catdvi | |-- catdvi.tar.gz | `-- sources | `-- PKGBUILD |-- dbhub | |-- dbhub.tar.gz | `-- sources | `-- PKGBUILD |-- grc | |-- grc.tar.gz | `-- sources | |-- PKGBUILD | `-- install.sh.patch |-- iimms2-git | |-- iimms2-git.tar.gz | `-- sources | |-- PKGBUILD | `-- config.mk `-- slim-theme-the_bait |-- slim-theme-the_bait.tar.gz `-- sources |-- PKGBUILD |-- slim-theme-the_bait-1.tar.gz `-- the_bait.install And of course a screenshot: http://omploader.org/vYWJi From xilonmu at gmail.com Mon Jan 7 07:52:58 2008 From: xilonmu at gmail.com (Sebastian Nowicki) Date: Mon, 7 Jan 2008 21:52:58 +0900 Subject: [aur-dev] AUR2 API Message-ID: <20080107125258.GB7370@Odin> We have most of what we need to implement the API, and I'm kind of eager to start on it. I thought it may be a good idea to start some discussion about how the API would work. I know there's an implementation in the works for the current AUR, in PHP, so it would be great if we got some implementation ideas from that too. Was there any discussions about that before? The two major functions of the API will be to search and retrieve information about a package. A utility may also want to retrieve comments and vote for package (if that feature was to be implemented). These are the "methods" I can think of: # Returns a tuple of package names that match (name and description is # searched), sorted by relevance # Regex may be used if implemented search(keywords) # Returns all info about the package, excluding dependencies and # such get_package_info(package_name) # Returns a tuple (array) of package names that the package depends on get_package_dependencies(package_name) # Returns a tuple of package comments (dictionary) get_package_comments(package_name) # Not sure about this one, I guess a url returned in get_package_info() # would suffice to use wget. I don't know how one would use JSON to # download a tarball get_package_tarball(package_name) From eduard.warkentin at gmail.com Mon Jan 7 18:49:11 2008 From: eduard.warkentin at gmail.com (Eduard Warkentin) Date: Tue, 08 Jan 2008 00:49:11 +0100 Subject: [aur-dev] aur for x86_64 Message-ID: <4782BA77.4010706@gmail.com> -----BEGIN PGP SIGNED MESSAGE----- Hash: RIPEMD160 Hi! I really would like to help aur to be usable for x86_64 packages too. I have no idea whats the current develop on that issue, but I really want to use it for x86_64 too. So if someone please can help me with the main issues at that point, i would be very happy :) Thx and greetings - -- Eduard "bekks" Warkentin GPG key id: 0x32217597 GPG fingerprint: 501B E562 2AF4 65FD EB85 A752 D07B D83D 3221 7597 GPG key server: hkp://subkeys.pgp.net -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEAREDAAYFAkeCum0ACgkQ0HvYPTIhdZdB/wCgvjezTkJzLAl4lcuuRRk6sUn1 YK4Anii4U1a9Tc/jkdWma/UOPFZDIv+s =815+ -----END PGP SIGNATURE----- From xilonmu at gmail.com Tue Jan 8 04:08:19 2008 From: xilonmu at gmail.com (Sebastian Nowicki) Date: Tue, 8 Jan 2008 18:08:19 +0900 Subject: [aur-dev] aur for x86_64 In-Reply-To: <4782BA77.4010706@gmail.com> References: <4782BA77.4010706@gmail.com> Message-ID: <20080108090819.GA7387@Odin> I wasn't aware that there was any issue. All that is required of the packages for them to build on the x86_64 architecture is to have "x86_64" in the arch array (ie. arch=(x86_64)) From eduard.warkentin at gmail.com Tue Jan 8 12:28:48 2008 From: eduard.warkentin at gmail.com (Eduard Warkentin) Date: Tue, 08 Jan 2008 18:28:48 +0100 Subject: [aur-dev] aur for x86_64 In-Reply-To: <20080108090819.GA7387@Odin> References: <4782BA77.4010706@gmail.com> <20080108090819.GA7387@Odin> Message-ID: <4783B2D0.6050806@gmail.com> -----BEGIN PGP SIGNED MESSAGE----- Hash: RIPEMD160 Hi1 Yes, for just building packages for x86_64 thats right. but those packages wont appear in AUR until now, which i think is not a good thing. And i really want to help to change that :) Sebastian Nowicki wrote: > I wasn't aware that there was any issue. All that is required of the > packages for them to build on the x86_64 architecture is to have > "x86_64" in the arch array (ie. arch=(x86_64)) - -- best regards, Eduard "bekks" Warkentin GPG key id: 0x32217597 GPG fingerprint: 501B E562 2AF4 65FD EB85 A752 D07B D83D 3221 7597 GPG key server: hkp://subkeys.pgp.net -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEAREDAAYFAkeDsr8ACgkQ0HvYPTIhdZcaxwCfb6AxmGHtITiq6zSZSsykA3N0 6X4AoJm+q62AsSSj1a9GI6z1s4TLsGSd =Ldd0 -----END PGP SIGNATURE----- From wizzomafizzo at gmail.com Wed Jan 9 21:15:55 2008 From: wizzomafizzo at gmail.com (Callan Barrett) Date: Thu, 10 Jan 2008 11:15:55 +0900 Subject: [aur-dev] [PATCH] Bug in uploading PKGBUILDs and aur schema Message-ID: <33f0f4ec0801091815i32173d9bg71d553dc9bfc1188@mail.gmail.com> This fixes a bug where TUs and devs couldn't upload packages because the query would have an extra column in it to mark the pkgbuild safe automatically, guessing it got missed when the safe flags were removed. Also fixes a screw up I made with the schema file when I added the tables for the voting app. -- Callan 'wizzomafizzo' Barrett -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-Bug-in-uploading-PKGBUILDs-and-aur-schema.patch Type: text/x-patch Size: 1810 bytes Desc: not available URL: From wizzomafizzo at gmail.com Fri Jan 11 11:00:05 2008 From: wizzomafizzo at gmail.com (Callan Barrett) Date: Sat, 12 Jan 2008 01:00:05 +0900 Subject: [aur-dev] [PATCH] Removes need for name, overwrite and comment fields from pkgsubmit.php Message-ID: <33f0f4ec0801110800i5a608545k7d55cb0f9010c377@mail.gmail.com> Alright, this patch gets rid of some fields in the pkgbuild submit form leaving just the category select and file select fields. As far as I can tell it works fine but I think this is an important patch that other people should test if possible, so if anyone reads these emails aside from cactus can you please try this out. -- Callan 'wizzomafizzo' Barrett From wizzomafizzo at gmail.com Fri Jan 11 11:01:19 2008 From: wizzomafizzo at gmail.com (Callan Barrett) Date: Sat, 12 Jan 2008 01:01:19 +0900 Subject: [aur-dev] [PATCH] Removes need for name, overwrite and comment fields from pkgsubmit.php In-Reply-To: <33f0f4ec0801110800i5a608545k7d55cb0f9010c377@mail.gmail.com> References: <33f0f4ec0801110800i5a608545k7d55cb0f9010c377@mail.gmail.com> Message-ID: <33f0f4ec0801110801y622f2325h2760b47756904bfa@mail.gmail.com> On Jan 12, 2008 1:00 AM, Callan Barrett wrote: > Alright, this patch gets rid of some fields in the pkgbuild submit > form leaving just the category select and file select fields. As far > as I can tell it works fine but I think this is an important patch > that other people should test if possible, so if anyone reads these > emails aside from cactus can you please try this out. Whoops, I'll also attach the patch. ;) -- Callan 'wizzomafizzo' Barrett -------------- next part -------------- A non-text attachment was scrubbed... Name: 0002-Removes-need-for-name-overwrite-and-comment-fields.patch Type: text/x-patch Size: 17484 bytes Desc: not available URL: From xilonmu at gmail.com Fri Jan 11 11:46:12 2008 From: xilonmu at gmail.com (Sebastian Nowicki) Date: Sat, 12 Jan 2008 01:46:12 +0900 Subject: [aur-dev] AUR2 New feature: Package Requests Message-ID: <20080111164612.GA23550@Odin> This morning I was looking for package requests, that I may be able to fill, on the bbs. After a few minutes of flipping through threads, I realised that nobody maintains the forum. These threads do not get edited properly to indicate that a request was filled. Every thread I looked at which seemed to be a request, was in fact already filled. Searching for a valid request seemed impossible. Who know how many threads spanning those 99 pages are actually filled or not? So I figured I may as well make a special section for it on the AUR site. The templates are a bit ugly still, and there's no searching implemented, nor do requests get marked as filled when a package gets submitted, but there's time for that. Here are some screenshots of what's done so far: http://img134.imageshack.us/img134/8855/200801120136181679x759sqm8.png http://img341.imageshack.us/img341/1507/200801120137081679x520seo8.png * http://img521.imageshack.us/img521/6889/200801120137171679x772ste9.png I discussed it with wizzo a bit and decided that comments weren't neccessary, but a "pkgbuild attempt" field would be useful. Any comments/discussion that people may have about the request can reside on the ML or bbs. * Request listing will have an "added" or "requested on" field From eliott at cactuswax.net Fri Jan 11 12:50:37 2008 From: eliott at cactuswax.net (eliott) Date: Fri, 11 Jan 2008 09:50:37 -0800 Subject: [aur-dev] AUR2 New feature: Package Requests In-Reply-To: <20080111164612.GA23550@Odin> References: <20080111164612.GA23550@Odin> Message-ID: <428d921d0801110950w4c48c33dk9bfa8aec67713512@mail.gmail.com> On 1/11/08, Sebastian Nowicki wrote: > This morning I was looking for package requests, that I may be able to > fill, on the bbs. After a few minutes of flipping through threads, I > realised that nobody maintains the forum. These threads do not get > edited properly to indicate that a request was filled. Every thread I > looked at which seemed to be a request, was in fact already filled. > Searching for a valid request seemed impossible. Who know how many > threads spanning those 99 pages are actually filled or not? > > So I figured I may as well make a special section for it on the AUR > site. The templates are a bit ugly still, and there's no searching > implemented, nor do requests get marked as filled when a package gets > submitted, but there's time for that. Here are some screenshots of > what's done so far: > > http://img134.imageshack.us/img134/8855/200801120136181679x759sqm8.png > http://img341.imageshack.us/img341/1507/200801120137081679x520seo8.png * > http://img521.imageshack.us/img521/6889/200801120137171679x772ste9.png > > I discussed it with wizzo a bit and decided that comments weren't > neccessary, but a "pkgbuild attempt" field would be useful. Any > comments/discussion that people may have about the request can reside on > the ML or bbs. > > * Request listing will have an "added" or "requested on" field I don't think I like this kind of thing being tied to the aur code. Requesting a package, or packaging assistance, shouldn't be a formal process. It should be informal, like most community requests for assistance. I think it should just remain a community aspect, and should be just something that happens on the forum or the mailing list. From roman.kyrylych at gmail.com Fri Jan 11 16:35:27 2008 From: roman.kyrylych at gmail.com (Roman Kyrylych) Date: Fri, 11 Jan 2008 23:35:27 +0200 Subject: [aur-dev] AUR2 New feature: Package Requests In-Reply-To: <428d921d0801110950w4c48c33dk9bfa8aec67713512@mail.gmail.com> References: <20080111164612.GA23550@Odin> <428d921d0801110950w4c48c33dk9bfa8aec67713512@mail.gmail.com> Message-ID: <577f15290801111335v6fff2e06wc94166e3f091dc82@mail.gmail.com> 2008/1/11, eliott : > On 1/11/08, Sebastian Nowicki wrote: > > This morning I was looking for package requests, that I may be able to > > fill, on the bbs. After a few minutes of flipping through threads, I > > realised that nobody maintains the forum. These threads do not get > > edited properly to indicate that a request was filled. Every thread I > > looked at which seemed to be a request, was in fact already filled. > > Searching for a valid request seemed impossible. Who know how many > > threads spanning those 99 pages are actually filled or not? > > > > So I figured I may as well make a special section for it on the AUR > > site. The templates are a bit ugly still, and there's no searching > > implemented, nor do requests get marked as filled when a package gets > > submitted, but there's time for that. Here are some screenshots of > > what's done so far: > > > > http://img134.imageshack.us/img134/8855/200801120136181679x759sqm8.png > > http://img341.imageshack.us/img341/1507/200801120137081679x520seo8.png * > > http://img521.imageshack.us/img521/6889/200801120137171679x772ste9.png > > > > I discussed it with wizzo a bit and decided that comments weren't > > neccessary, but a "pkgbuild attempt" field would be useful. Any > > comments/discussion that people may have about the request can reside on > > the ML or bbs. > > > > * Request listing will have an "added" or "requested on" field > > I don't think I like this kind of thing being tied to the aur code. > > Requesting a package, or packaging assistance, shouldn't be a formal > process. It should be informal, like most community requests for > assistance. I think it should just remain a community aspect, and > should be just something that happens on the forum or the mailing > list. > There is a "package requests" branch on our forums. -- Roman Kyrylych (????? ???????) From xilonmu at gmail.com Fri Jan 11 23:25:35 2008 From: xilonmu at gmail.com (Sebastian Nowicki) Date: Sat, 12 Jan 2008 13:25:35 +0900 Subject: [aur-dev] AUR2 New feature: Package Requests In-Reply-To: <428d921d0801110950w4c48c33dk9bfa8aec67713512@mail.gmail.com> References: <20080111164612.GA23550@Odin> <428d921d0801110950w4c48c33dk9bfa8aec67713512@mail.gmail.com> Message-ID: <20080112042535.GA7446@Odin> On Fri, Jan 11, 2008 at 09:50:37AM -0800, eliott wrote: > Requesting a package, or packaging assistance, shouldn't be a formal > process. It should be informal, like most community requests for > assistance. I think it should just remain a community aspect, and > should be just something that happens on the forum or the mailing > list. > As I mentioned in the previous post, the bbs just does not work. The mailing list doesn't seem like the right place either, since it moves along and posts can be forgotten. It's not really persistent. I think having the requests on the AUR is very logical, it's more automated, organised, easier to search for requests, and filled requests automatically drop off the listing. No maintenance is required since the code does everything. The user is required to give a decent amount of information, which people fail to do on the bbs. Only one account is required to post requests and packages, instead of one for the AUR and one for the bbs. Just because people aren't able to freely post comments and such doesn't mean that there is no community aspect. In my opinion the AUR is very much a community project and I don't see why requests shouldn't be in the same place as the packages. From wizzomafizzo at gmail.com Sat Jan 12 04:18:43 2008 From: wizzomafizzo at gmail.com (Callan Barrett) Date: Sat, 12 Jan 2008 18:18:43 +0900 Subject: [aur-dev] [PATCH] Tweaks of various page layouts and handling of data Message-ID: <33f0f4ec0801120118o600a9664j496c2a0113a68c8f@mail.gmail.com> This is a patch that fixes a lot of little things: * We no longer have pkgsearch or pkgdetails link functions and all references to them are gone, that's what a back button is for and if we really need it we can come up with something better * No longer have do_Details variable, this means links on the package search are simply ?ID=foo * On the pkgdetails pages when there are either no deps, deps by, sources or comments for a package the list for each will display "None" instead of nothing at all (ruining the layout) * Fixed a bug where if a package had no sources or no deps pkgsubmit.php would submit an empty one * Translation of the word "Search'" has been changed to "Search" Most of these relate to each other. -- Callan 'wizzomafizzo' Barrett -------------- next part -------------- A non-text attachment was scrubbed... Name: 0003-Tweaks-of-various-page-layouts-and-handling-of-data.patch Type: text/x-patch Size: 29396 bytes Desc: not available URL: From wizzomafizzo at gmail.com Sat Jan 12 09:05:08 2008 From: wizzomafizzo at gmail.com (Callan Barrett) Date: Sat, 12 Jan 2008 23:05:08 +0900 Subject: [aur-dev] [PATCH] Support for verbose page titles Message-ID: <1200146708-25174-1-git-send-email-wizzomafizzo@gmail.com> Adds support for more verbose page titles based on current page and action by user and removes sort by options from search form as they're obsolete by column links. Signed-off-by: Callan Barrett --- web/html/account.php | 2 +- web/html/index.php | 5 +-- web/html/packages.php | 19 ++++++++++++- web/html/pkgsubmit.php | 2 +- web/lib/aur.inc | 4 ++- web/lib/pkgfuncs.inc | 71 ++++++++++++----------------------------------- web/template/header.php | 2 +- 7 files changed, 43 insertions(+), 62 deletions(-) diff --git a/web/html/account.php b/web/html/account.php index 9caada4..9c1eb31 100644 --- a/web/html/account.php +++ b/web/html/account.php @@ -8,7 +8,7 @@ include("pkgfuncs_po.inc"); # Add to handle the i18n of My Packages include("account_po.inc"); # use some form of this for i18n support set_lang(); # this sets up the visitor's language check_sid(); # see if they're still logged in -html_header(); # print out the HTML header +html_header(__("Accounts")); # print out the HTML header # Main page processing here diff --git a/web/html/index.php b/web/html/index.php index 99cccbc..617b16a 100644 --- a/web/html/index.php +++ b/web/html/index.php @@ -7,10 +7,7 @@ include("pkgfuncs_po.inc"); # Add to handle the i18n of My Packages include("aur.inc"); set_lang(); check_sid(); - -# Any cookies have been sent, can now display HTML -# -html_header(); +html_header(__("Home")); # Big Top Level Table (Table 1) echo "
\n"; diff --git a/web/html/packages.php b/web/html/packages.php index bc398ee..1600e41 100644 --- a/web/html/packages.php +++ b/web/html/packages.php @@ -7,7 +7,24 @@ include("pkgfuncs.inc"); # package specific functions include("search_po.inc"); # use some form of this for i18n support set_lang(); # this sets up the visitor's language check_sid(); # see if they're still logged in -html_header(); # print out the HTML header + +# set the title to something useful depending on +# what "page" we're on +# +if (isset($_GET['ID'])) { + $id = pkgname_from_id($_GET['ID']); + if (!empty($id)) { + $title = $id; + } +} else if (isset($_GET['K'])) { + $title = "Search: " . $_GET['K']; +} else if (isset($_GET['do_MyPackages'])) { + $title = __("My Packages"); +} else { + $title = __("Packages"); +} + +html_header($title); # print out the HTML header # enable debugging # diff --git a/web/html/pkgsubmit.php b/web/html/pkgsubmit.php index 638654b..801348b 100644 --- a/web/html/pkgsubmit.php +++ b/web/html/pkgsubmit.php @@ -8,7 +8,7 @@ include("pkgfuncs.inc"); # package functions include("config.inc"); # configuration file with dir locations set_lang(); # this sets up the visitor's language check_sid(); # see if they're still logged in -html_header(); # print out the HTML header +html_header("Submit"); # print out the HTML header echo "
\n"; echo "
".__("Submit")."
\n"; echo "
\n"; diff --git a/web/lib/aur.inc b/web/lib/aur.inc index c18365c..a9095cd 100644 --- a/web/lib/aur.inc +++ b/web/lib/aur.inc @@ -334,7 +334,7 @@ function set_lang() { # common header # -function html_header() { +function html_header($title="") { global $_SERVER; global $_COOKIE; global $_POST; @@ -405,6 +405,8 @@ function html_header() { } } + $title = htmlspecialchars($title, ENT_QUOTES); + include('header.php'); return; } diff --git a/web/lib/pkgfuncs.inc b/web/lib/pkgfuncs.inc index 46bc522..d4f3ae7 100644 --- a/web/lib/pkgfuncs.inc +++ b/web/lib/pkgfuncs.inc @@ -250,6 +250,23 @@ function pkgnotify_from_sid($sid="") { return $pkgs; } +# get name of package based on pkgid +# +function pkgname_from_id($id="") { + if (!empty($id)) { + $dbh = db_connect(); + $id = intval($id); + $q = "SELECT Name FROM Packages WHERE ID = " . mysql_real_escape_string($id); + $result = db_query($q, $dbh); + if (mysql_num_rows($result) > 0) { + $id = mysql_result($result, 0); + } else { + $id = ""; + } + } + return $id; +} + # display package details # function package_details($id=0, $SID="") { @@ -638,7 +655,7 @@ function pkg_search_page($SID="") { # The search form # - print "
\n"; + print "\n"; print "\n"; print "
\n"; @@ -714,58 +731,6 @@ function pkg_search_page($SID="") { print " \n"; print "\n"; - /* Sort by */ - - print "\n"; - print " ".__("Sort by"); - print "
\n"; - print " \n"; - print "\n"; - - print "\n"; - print " ".__("Sort order"); - print "
\n"; - print " \n"; - print "\n"; - - /* End of Sort by */ - print "\n"; print " ".__("Per page"); print "
\n"; diff --git a/web/template/header.php b/web/template/header.php index 8e02211..b27015a 100644 --- a/web/template/header.php +++ b/web/template/header.php @@ -4,7 +4,7 @@ "> - AUR (<?php print $LANG; ?>) + AUR (<?php print $LANG; ?>)<?php if ($title != "") { print " - " . $title; } ?> -- 1.5.3.7 From wizzomafizzo at gmail.com Sat Jan 12 17:43:05 2008 From: wizzomafizzo at gmail.com (Callan Barrett) Date: Sun, 13 Jan 2008 07:43:05 +0900 Subject: [aur-dev] [PATCH] Support for verbose page titles Message-ID: <33f0f4ec0801121443w1c812010le2f63dbfc24e9bdf@mail.gmail.com> Verbose page titles again -- Callan 'wizzomafizzo' Barrett -------------- next part -------------- A non-text attachment was scrubbed... Name: 0004-Support-for-verbose-page-titles.patch Type: text/x-patch Size: 7232 bytes Desc: not available URL: From louipc.ist at gmail.com Sat Jan 12 18:53:19 2008 From: louipc.ist at gmail.com (Loui) Date: Sat, 12 Jan 2008 18:53:19 -0500 Subject: [aur-dev] [PATCH] Tweaks of various page layouts and handling of data In-Reply-To: <33f0f4ec0801120118o600a9664j496c2a0113a68c8f@mail.gmail.com> References: <33f0f4ec0801120118o600a9664j496c2a0113a68c8f@mail.gmail.com> Message-ID: <50673e970801121553k71c3ed90m217064c8326734aa@mail.gmail.com> Hey is someone applying all your patches to the official repo? It doesn't seem like it. Maybe you can bug someone to give you push access. From wizzomafizzo at gmail.com Sat Jan 12 20:08:41 2008 From: wizzomafizzo at gmail.com (Callan Barrett) Date: Sun, 13 Jan 2008 10:08:41 +0900 Subject: [aur-dev] [PATCH] Tweaks of various page layouts and handling of data In-Reply-To: <50673e970801121553k71c3ed90m217064c8326734aa@mail.gmail.com> References: <33f0f4ec0801120118o600a9664j496c2a0113a68c8f@mail.gmail.com> <50673e970801121553k71c3ed90m217064c8326734aa@mail.gmail.com> Message-ID: <33f0f4ec0801121708p4839712cu2c342a1707c3487b@mail.gmail.com> On Jan 13, 2008 8:53 AM, Loui wrote: > Hey is someone applying all your patches to the official repo? It > doesn't seem like it. > Maybe you can bug someone to give you push access. Not to the official repo but cactus is applying them to his which is apparently where all the action is. -- Callan 'wizzomafizzo' Barrett From simo at archlinux.org Sat Jan 12 20:19:44 2008 From: simo at archlinux.org (Simo Leone) Date: Sat, 12 Jan 2008 19:19:44 -0600 Subject: [aur-dev] [PATCH] Tweaks of various page layouts and handling of data In-Reply-To: <33f0f4ec0801121708p4839712cu2c342a1707c3487b@mail.gmail.com> References: <33f0f4ec0801120118o600a9664j496c2a0113a68c8f@mail.gmail.com> <50673e970801121553k71c3ed90m217064c8326734aa@mail.gmail.com> <33f0f4ec0801121708p4839712cu2c342a1707c3487b@mail.gmail.com> Message-ID: <20080113011944.GB24426@archlinux.org> On Sun, Jan 13, 2008 at 10:08:41AM +0900, Callan Barrett wrote: > On Jan 13, 2008 8:53 AM, Loui wrote: > > Hey is someone applying all your patches to the official repo? It > > doesn't seem like it. > > Maybe you can bug someone to give you push access. > > Not to the official repo but cactus is applying them to his which is > apparently where all the action is. > I'm rather busy with random stuff for a while. But yes, I'll be merging cactus's branch, he's been collecting the goodies for me (thanks dude!). I'll probably get my first chance to seriously look at it this week. -S -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available URL: From dan at archlinux.org Sun Jan 13 21:40:21 2008 From: dan at archlinux.org (Dan McGee) Date: Sun, 13 Jan 2008 20:40:21 -0600 Subject: [aur-dev] [PATCH] Allow pkgsubmit to accept any tar* file Message-ID: <1200278421-29727-1-git-send-email-dan@archlinux.org> Instead of restricting to gz and bz2, allow just plain tar and any other format tar can understand to be uploaded. I make the mistake all the time of forgetting to pass -z to tar when making something to upload, and there is no real reason to exclude plain tar files. Signed-off-by: Dan McGee --- web/html/pkgsubmit.php | 9 ++------- 1 files changed, 2 insertions(+), 7 deletions(-) diff --git a/web/html/pkgsubmit.php b/web/html/pkgsubmit.php index 6e754bf..44b5070 100644 --- a/web/html/pkgsubmit.php +++ b/web/html/pkgsubmit.php @@ -121,14 +121,9 @@ if ($_COOKIE["AURSID"]) { $error = __("Could not change directory to %s.", array(INCOMING_DIR.$pkg_name)); } else { - # try .gz first + # try using general tar. it should take .gz, .bz2, and plain .tar # - exec("/bin/sh -c 'tar xzf ".$upload_file."'", $trash, $retval); - if (!$retval) { - # now try .bz2 format - # - exec("/bin/sh -c 'tar xjf ".$upload_file."'", $trash, $retval); - } + exec("/bin/sh -c 'tar xf ".$upload_file."'", $trash, $retval); if (!$retval) { $error = __("Unknown file format for uploaded file."); } -- 1.5.4.rc3 From dan at archlinux.org Sun Jan 13 21:52:44 2008 From: dan at archlinux.org (Dan McGee) Date: Sun, 13 Jan 2008 20:52:44 -0600 Subject: [aur-dev] [PATCH] Allow pkgsubmit to accept any tar* file In-Reply-To: <1200278421-29727-1-git-send-email-dan@archlinux.org> References: <1200278421-29727-1-git-send-email-dan@archlinux.org> Message-ID: <1200279164-30003-1-git-send-email-dan@archlinux.org> Instead of restricting to gz and bz2, allow just plain tar and any other format tar can understand to be uploaded. I make the mistake all the time of forgetting to pass -z to tar when making something to upload, and there is no real reason to exclude plain tar files. Signed-off-by: Dan McGee --- Hey-o. The same patch as the earlier one in this thread, except it is based off of cactus/testing, since it looks like that is where the real work is getting done right now. PLEASE make this change. :) -Dan web/html/pkgsubmit.php | 8 +++----- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/web/html/pkgsubmit.php b/web/html/pkgsubmit.php index 801348b..ccf66c1 100644 --- a/web/html/pkgsubmit.php +++ b/web/html/pkgsubmit.php @@ -47,11 +47,9 @@ if ($_COOKIE["AURSID"]) { $error = __("Could not change directory to %s.", array(UPLOAD_DIR . $tempdir)); } else { - exec("/bin/sh -c 'tar xzf " . $_FILES["pfile"]["tmp_name"] . "'", $trash, $retval); - if ($retval) { - exec("/bin/sh -c 'tar xjf " . $_FILES["pfile"]["tmp_name"] . "'", $trash, $retval); - } - if ($retval) { + # try using general tar. it should take .gz, .bz2, and plain .tar + exec("/bin/sh -c 'tar xf ".$upload_file."'", $trash, $retval); + if (!$retval) { $error = __("Unknown file format for uploaded file."); } } -- 1.5.4.rc3 From eliott at cactuswax.net Sun Jan 13 21:59:07 2008 From: eliott at cactuswax.net (eliott) Date: Sun, 13 Jan 2008 18:59:07 -0800 Subject: [aur-dev] [PATCH] Allow pkgsubmit to accept any tar* file In-Reply-To: <1200278421-29727-1-git-send-email-dan@archlinux.org> References: <1200278421-29727-1-git-send-email-dan@archlinux.org> Message-ID: <428d921d0801131859g6fac1e68wcfff09d0144df72f@mail.gmail.com> for whatever reason, I cannot apply patches like this. The inline fails every time with hunks not applying. Attached patches (even the exact same ones) work flawlessly. It could be the specific version of git i am using, but that doesn't seem to be the problem. I blame gmail currently. error: patch failed: web/html/pkgsubmit.php:121 error: web/html/pkgsubmit.php: patch does not apply Patch failed at 0001. On 1/13/08, Dan McGee wrote: > Instead of restricting to gz and bz2, allow just plain tar and any other > format tar can understand to be uploaded. I make the mistake all the time of > forgetting to pass -z to tar when making something to upload, and there is > no real reason to exclude plain tar files. > > Signed-off-by: Dan McGee > --- > web/html/pkgsubmit.php | 9 ++------- > 1 files changed, 2 insertions(+), 7 deletions(-) > > diff --git a/web/html/pkgsubmit.php b/web/html/pkgsubmit.php > index 6e754bf..44b5070 100644 > --- a/web/html/pkgsubmit.php > +++ b/web/html/pkgsubmit.php > @@ -121,14 +121,9 @@ if ($_COOKIE["AURSID"]) { > $error = __("Could not change directory to %s.", > array(INCOMING_DIR.$pkg_name)); > } else { > - # try .gz first > + # try using general tar. it should take .gz, .bz2, and plain .tar > # > - exec("/bin/sh -c 'tar xzf ".$upload_file."'", $trash, $retval); > - if (!$retval) { > - # now try .bz2 format > - # > - exec("/bin/sh -c 'tar xjf ".$upload_file."'", $trash, $retval); > - } > + exec("/bin/sh -c 'tar xf ".$upload_file."'", $trash, $retval); > if (!$retval) { > $error = __("Unknown file format for uploaded file."); > } > -- > 1.5.4.rc3 > > > From eliott at cactuswax.net Sun Jan 13 22:04:36 2008 From: eliott at cactuswax.net (eliott) Date: Sun, 13 Jan 2008 19:04:36 -0800 Subject: [aur-dev] [PATCH] Allow pkgsubmit to accept any tar* file In-Reply-To: <1200279164-30003-1-git-send-email-dan@archlinux.org> References: <1200278421-29727-1-git-send-email-dan@archlinux.org> <1200279164-30003-1-git-send-email-dan@archlinux.org> Message-ID: <428d921d0801131904y12946988r1bf197347b5e4193@mail.gmail.com> This one applied... however, I had to copy/paste with a different editor. I think my vim config (convert tabs to spaces) is causing the problem. This is a big failure of using inline and having to copy paste. Remember kids..dont use tabs, they make cactus cry. On 1/13/08, Dan McGee wrote: > Instead of restricting to gz and bz2, allow just plain tar and any other > format tar can understand to be uploaded. I make the mistake all the time of > forgetting to pass -z to tar when making something to upload, and there is > no real reason to exclude plain tar files. > > Signed-off-by: Dan McGee > --- > > Hey-o. The same patch as the earlier one in this thread, except it is based > off of cactus/testing, since it looks like that is where the real work is > getting done right now. > > PLEASE make this change. :) > > -Dan > > web/html/pkgsubmit.php | 8 +++----- > 1 files changed, 3 insertions(+), 5 deletions(-) > > diff --git a/web/html/pkgsubmit.php b/web/html/pkgsubmit.php > index 801348b..ccf66c1 100644 > --- a/web/html/pkgsubmit.php > +++ b/web/html/pkgsubmit.php > @@ -47,11 +47,9 @@ if ($_COOKIE["AURSID"]) { > $error = __("Could not change directory to %s.", > array(UPLOAD_DIR . $tempdir)); > } else { > - exec("/bin/sh -c 'tar xzf " . $_FILES["pfile"]["tmp_name"] . "'", $trash, $retval); > - if ($retval) { > - exec("/bin/sh -c 'tar xjf " . $_FILES["pfile"]["tmp_name"] . "'", $trash, $retval); > - } > - if ($retval) { > + # try using general tar. it should take .gz, .bz2, and plain .tar > + exec("/bin/sh -c 'tar xf ".$upload_file."'", $trash, $retval); > + if (!$retval) { > $error = __("Unknown file format for uploaded file."); > } > } > -- > 1.5.4.rc3 > > > From aaronmgriffin at gmail.com Mon Jan 14 01:15:26 2008 From: aaronmgriffin at gmail.com (Aaron Griffin) Date: Mon, 14 Jan 2008 00:15:26 -0600 Subject: [aur-dev] [PATCH] Allow pkgsubmit to accept any tar* file In-Reply-To: <428d921d0801131904y12946988r1bf197347b5e4193@mail.gmail.com> References: <1200278421-29727-1-git-send-email-dan@archlinux.org> <1200279164-30003-1-git-send-email-dan@archlinux.org> <428d921d0801131904y12946988r1bf197347b5e4193@mail.gmail.com> Message-ID: On Jan 13, 2008 9:04 PM, eliott wrote: > This one applied... however, I had to copy/paste with a different editor. > I think my vim config (convert tabs to spaces) is causing the problem. > This is a big failure of using inline and having to copy paste. Are you doing copy/pasta from gmail? I always had problems there. Does it do the same when you "view original" and "save as"? For me that always works (after removing the first blank line). > Remember kids..dont use tabs, they make cactus cry. He says, as he top-posts. From eliott at cactuswax.net Mon Jan 14 14:07:23 2008 From: eliott at cactuswax.net (eliott) Date: Mon, 14 Jan 2008 11:07:23 -0800 Subject: [aur-dev] [PATCH] Allow pkgsubmit to accept any tar* file In-Reply-To: References: <1200278421-29727-1-git-send-email-dan@archlinux.org> <1200279164-30003-1-git-send-email-dan@archlinux.org> <428d921d0801131904y12946988r1bf197347b5e4193@mail.gmail.com> Message-ID: <428d921d0801141107x5a504fa3uaea086877f1cd2a1@mail.gmail.com> another fail of gmail. Top posting is standard. wtf! On 1/13/08, Aaron Griffin wrote: > Are you doing copy/pasta from gmail? yes > I always had problems there. Does > it do the same when you "view original" and "save as"? For me that > always works (after removing the first blank line). I tried save page as, but here is the kicker..i have to edit it to remove the first line. I narrowed it down to my vimrc of all things. I finally got it to work using mousepad (xfce gui text editor) after a save page as. Talk about failhouse. :( This seems like a real failing of the inline patch method. It is very fragile in regard to line breaks and tab interpretation. > > Remember kids..dont use tabs, they make cactus cry. > He says, as he top-posts. *shakes fist* From wizzomafizzo at gmail.com Mon Jan 14 23:25:29 2008 From: wizzomafizzo at gmail.com (Callan Barrett) Date: Tue, 15 Jan 2008 13:25:29 +0900 Subject: [aur-dev] [PATCH] Prefill category upon upload error and fix bug in last patch Message-ID: <1200371129-11113-1-git-send-email-wizzomafizzo@gmail.com> When a package upload fails the category value will be prefilled, fixes a bug in the previous patch where the pkgbuild would not extract properly and splits the html from php in the form so there are no more prints to output it Signed-off-by: Callan Barrett --- web/html/pkgsubmit.php | 87 +++++++++++++++++++++-------------------------- 1 files changed, 39 insertions(+), 48 deletions(-) -------------- next part -------------- A non-text attachment was scrubbed... Name: a6e0285f5a3e570de8ebf0f3456939027f2bb078.diff Type: text/x-patch Size: 3863 bytes Desc: not available URL: From wizzomafizzo at gmail.com Tue Jan 15 01:54:23 2008 From: wizzomafizzo at gmail.com (Callan Barrett) Date: Tue, 15 Jan 2008 15:54:23 +0900 Subject: [aur-dev] [PATCH] More cleanup, add TU link to header Message-ID: <1200380063-7480-1-git-send-email-wizzomafizzo@gmail.com> Cleans up links on front page, adds a TU link to the header to the voting application, fixes some titles and styling for logged in text Signed-off-by: Callan Barrett --- web/html/index.php | 2 +- web/html/packages.php | 2 +- web/lang/en/aur_po.inc | 4 +++- web/lib/aur.inc | 23 ----------------------- web/lib/pkgfuncs.inc | 8 ++++---- web/template/header.php | 19 +++++++++++++------ 6 files changed, 22 insertions(+), 36 deletions(-) -------------- next part -------------- A non-text attachment was scrubbed... Name: c378e554a452931653461860cd434a9cde5433d0.diff Type: text/x-patch Size: 4420 bytes Desc: not available URL: From louipc.ist at gmail.com Tue Jan 15 02:12:27 2008 From: louipc.ist at gmail.com (Loui) Date: Tue, 15 Jan 2008 02:12:27 -0500 Subject: [aur-dev] [PATCH] More cleanup, add TU link to header In-Reply-To: <1200380063-7480-1-git-send-email-wizzomafizzo@gmail.com> References: <1200380063-7480-1-git-send-email-wizzomafizzo@gmail.com> Message-ID: <50673e970801142312u78985e8avb3af72f9196cdf43@mail.gmail.com> Man you're a machine! On Jan 15, 2008 1:54 AM, Callan Barrett wrote: > > Cleans up links on front page, adds a TU link to the header to the voting > application, fixes some titles and styling for logged in text > > Signed-off-by: Callan Barrett > --- > web/html/index.php | 2 +- > web/html/packages.php | 2 +- > web/lang/en/aur_po.inc | 4 +++- > web/lib/aur.inc | 23 ----------------------- > web/lib/pkgfuncs.inc | 8 ++++---- > web/template/header.php | 19 +++++++++++++------ > 6 files changed, 22 insertions(+), 36 deletions(-) From wizzomafizzo at gmail.com Tue Jan 15 04:59:48 2008 From: wizzomafizzo at gmail.com (Callan Barrett) Date: Tue, 15 Jan 2008 18:59:48 +0900 Subject: [aur-dev] [PATCH] Add search result information Message-ID: <1200391188-28035-1-git-send-email-wizzomafizzo@gmail.com> This adds search results numbers to the bottom of pages when searching based on tardo's repository, ex. Showing results 1 - 42 of 42 Signed-off-by: Callan Barrett --- web/lang/en/pkgfuncs_po.inc | 2 + web/lib/pkgfuncs.inc | 66 +++++++++++++++++++++++------------------- 2 files changed, 38 insertions(+), 30 deletions(-) -------------- next part -------------- A non-text attachment was scrubbed... Name: 1bbc7f7ee42c5fe4ad14bf487534405e58206018.diff Type: text/x-patch Size: 3674 bytes Desc: not available URL: From wizzomafizzo at gmail.com Thu Jan 17 03:04:00 2008 From: wizzomafizzo at gmail.com (Callan Barrett) Date: Thu, 17 Jan 2008 17:04:00 +0900 Subject: [aur-dev] [PATCH] Fix login error and translation bug Message-ID: <1200557040-28734-1-git-send-email-wizzomafizzo@gmail.com> Fixes a login error where entering nothing would result in the login message "Incorrect password for username, ." and changes the translation "TU" to "Trusted User" so the menu bar on the accounts page doesn't bug up (we need a new translation system :((() Signed-off-by: Callan Barrett --- web/lang/en/aur_po.inc | 2 +- web/lib/aur.inc | 4 ++-- web/template/header.php | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) -------------- next part -------------- A non-text attachment was scrubbed... Name: 557af1755fc375e4461ae04df8a2706b32bb7ca2.diff Type: text/x-patch Size: 1653 bytes Desc: not available URL: From wizzomafizzo at gmail.com Thu Jan 17 11:11:12 2008 From: wizzomafizzo at gmail.com (Callan Barrett) Date: Fri, 18 Jan 2008 01:11:12 +0900 Subject: [aur-dev] [PATCH] Turn action bar into drop box Message-ID: <1200586272-18378-1-git-send-email-wizzomafizzo@gmail.com> Moves the action bar down to the bottom right of the search results and turns it into a drop-down selection box. Signed-off-by: Callan Barrett --- web/html/packages.php | 26 ++++++++--------- web/lang/en/search_po.inc | 2 +- web/lib/pkgfuncs.inc | 67 ++++++++++++++------------------------------- web/template/header.php | 2 +- 4 files changed, 35 insertions(+), 62 deletions(-) -------------- next part -------------- A non-text attachment was scrubbed... Name: 8a578d54ba9a141961924a903bcaf32b9b15665a.diff Type: text/x-patch Size: 8316 bytes Desc: not available URL: From simo at archlinux.org Sun Jan 20 04:38:06 2008 From: simo at archlinux.org (Simo Leone) Date: Sun, 20 Jan 2008 03:38:06 -0600 Subject: [aur-dev] Testing branch updates Message-ID: <20080120093806.GA12557@neotuli.net> Hey everyone, Just a quick note that the testing branch on projects.archlinux.org was forced to a non-superset tonight. The messy merge history has been cleaned up (thanks Dan!), and Eliott's testing branch was merged and cleaned up a bit. At this point, I'd also like to mention a few other business items: - I'm running a test site at aur.neotuli.net, I will keep this site running the testing branch from projects.archlinux.org, updated as often as I can. - I've changed the structure of the git repo on projects.archlinux.org a a little bit as well. I removed the 'stable' branch. From here on out, 'master' will be the stable branch and will get tagged at releases. 'testing' will remain a place to test code headed for master. - I want to set up a workflow like pacman's, where any patches headed for the AUR pass through the mailing list. This is the easiest way for me to manage incoming patches, and will avoid funky situations like the double merges and such that we saw in the past. - We're headed for another AUR release very shortly. Probably within a week I'll be pushing out what we've got in the testing branch, so if you had any last minute code you wanted to see go up, now's the time :) -Simo -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available URL: From roman.kyrylych at gmail.com Sun Jan 20 04:54:52 2008 From: roman.kyrylych at gmail.com (Roman Kyrylych) Date: Sun, 20 Jan 2008 11:54:52 +0200 Subject: [aur-dev] Testing branch updates In-Reply-To: <20080120093806.GA12557@neotuli.net> References: <20080120093806.GA12557@neotuli.net> Message-ID: <577f15290801200154q48b78324odbbd10f03201c4dd@mail.gmail.com> 2008/1/20, Simo Leone : > Hey everyone, > > Just a quick note that the testing branch on projects.archlinux.org was > forced to a non-superset tonight. The messy merge history has been > cleaned up (thanks Dan!), and Eliott's testing branch was merged and > cleaned up a bit. > > At this point, I'd also like to mention a few other business items: > - I'm running a test site at aur.neotuli.net, I will keep this site > running the testing branch from projects.archlinux.org, updated as > often as I can. > - I've changed the structure of the git repo on projects.archlinux.org a > a little bit as well. I removed the 'stable' branch. From here on out, > 'master' will be the stable branch and will get tagged at releases. > 'testing' will remain a place to test code headed for master. > - I want to set up a workflow like pacman's, where any patches headed > for the AUR pass through the mailing list. This is the easiest way for > me to manage incoming patches, and will avoid funky situations like > the double merges and such that we saw in the past. > - We're headed for another AUR release very shortly. Probably within a > week I'll be pushing out what we've got in the testing branch, so if > you had any last minute code you wanted to see go up, now's the time :) > http://aur.neotuli.net/ displays Parse error: syntax error, unexpected T_STRING in /home/.misha/neotuli/aur.neotuli.net/web/template/header.php on line 1 -- Roman Kyrylych (????? ???????) From simo at archlinux.org Sun Jan 20 05:39:17 2008 From: simo at archlinux.org (Simo Leone) Date: Sun, 20 Jan 2008 04:39:17 -0600 Subject: [aur-dev] Testing branch updates In-Reply-To: <577f15290801200154q48b78324odbbd10f03201c4dd@mail.gmail.com> References: <20080120093806.GA12557@neotuli.net> <577f15290801200154q48b78324odbbd10f03201c4dd@mail.gmail.com> Message-ID: <20080120103917.GA12639@neotuli.net> On Sun, Jan 20, 2008 at 11:54:52AM +0200, Roman Kyrylych wrote: > 2008/1/20, Simo Leone : > > Hey everyone, > > > > Just a quick note that the testing branch on projects.archlinux.org was > > forced to a non-superset tonight. The messy merge history has been > > cleaned up (thanks Dan!), and Eliott's testing branch was merged and > > cleaned up a bit. > > > > At this point, I'd also like to mention a few other business items: > > - I'm running a test site at aur.neotuli.net, I will keep this site > > running the testing branch from projects.archlinux.org, updated as > > often as I can. > > - I've changed the structure of the git repo on projects.archlinux.org a > > a little bit as well. I removed the 'stable' branch. From here on out, > > 'master' will be the stable branch and will get tagged at releases. > > 'testing' will remain a place to test code headed for master. > > - I want to set up a workflow like pacman's, where any patches headed > > for the AUR pass through the mailing list. This is the easiest way for > > me to manage incoming patches, and will avoid funky situations like > > the double merges and such that we saw in the past. > > - We're headed for another AUR release very shortly. Probably within a > > week I'll be pushing out what we've got in the testing branch, so if > > you had any last minute code you wanted to see go up, now's the time :) > > > > http://aur.neotuli.net/ displays > Parse error: syntax error, unexpected T_STRING in > /home/.misha/neotuli/aur.neotuli.net/web/template/header.php on line 1 > dreamhost-related issue. aparently they run php through fcgi which means .htaccess files can't affect php at all. lovely. I worked around it. -S -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available URL: From roman.kyrylych at gmail.com Sun Jan 20 05:58:06 2008 From: roman.kyrylych at gmail.com (Roman Kyrylych) Date: Sun, 20 Jan 2008 12:58:06 +0200 Subject: [aur-dev] Testing branch updates In-Reply-To: <20080120103917.GA12639@neotuli.net> References: <20080120093806.GA12557@neotuli.net> <577f15290801200154q48b78324odbbd10f03201c4dd@mail.gmail.com> <20080120103917.GA12639@neotuli.net> Message-ID: <577f15290801200258r354ec578wf52912337fb97b1a@mail.gmail.com> 2008/1/20, Simo Leone : > On Sun, Jan 20, 2008 at 11:54:52AM +0200, Roman Kyrylych wrote: > > http://aur.neotuli.net/ displays > > Parse error: syntax error, unexpected T_STRING in > > /home/.misha/neotuli/aur.neotuli.net/web/template/header.php on line 1 > > > dreamhost-related issue. aparently they run php through fcgi which means > .htaccess files can't affect php at all. lovely. I worked around it. Ah, I've had the same issue 2 days ago when setting up lighttpd+fastcgi+php. Solved with http://pecl.php.net/package/htscanner -- Roman Kyrylych (????? ???????) From simo at archlinux.org Sun Jan 20 06:26:02 2008 From: simo at archlinux.org (Simo Leone) Date: Sun, 20 Jan 2008 05:26:02 -0600 Subject: [aur-dev] Testing branch updates In-Reply-To: <577f15290801200258r354ec578wf52912337fb97b1a@mail.gmail.com> References: <20080120093806.GA12557@neotuli.net> <577f15290801200154q48b78324odbbd10f03201c4dd@mail.gmail.com> <20080120103917.GA12639@neotuli.net> <577f15290801200258r354ec578wf52912337fb97b1a@mail.gmail.com> Message-ID: <20080120112602.GA13008@neotuli.net> Also, quick note to anyone that happens to be testing... if you try to upload a tar.gz or tar.bz2 (anything but a plain pkgbuild or .tar), you'll find that it claims not to recognize the format. This is just a limitation of the version of tar running on the dreamhost box, in reality these other formats work just fine. -- Simo Leone Arch Linux Developer -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available URL: From simo at archlinux.org Sun Jan 20 17:15:48 2008 From: simo at archlinux.org (Simo Leone) Date: Sun, 20 Jan 2008 16:15:48 -0600 Subject: [aur-dev] Call for translations Message-ID: <20080120221548.GA13710@neotuli.net> A few of our translations have a couple missing strings. If you guys could take a look and reply with updates, that'd be awesome.e Thanks, -S -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available URL: From linuxmania at gmail.com Sun Jan 20 21:01:38 2008 From: linuxmania at gmail.com (Giovanni Scafora) Date: Mon, 21 Jan 2008 03:01:38 +0100 Subject: [aur-dev] Call for translations In-Reply-To: <20080120221548.GA13710@neotuli.net> References: <20080120221548.GA13710@neotuli.net> Message-ID: 2008/1/20, Simo Leone : > A few of our translations have a couple missing strings. If you guys > could take a look and reply with updates, that'd be awesome.e I will send you the updated Italian translation in the next 24-48 hours. Thanks. -- Giovanni Scafora Arch Linux Trusted User (voidnull) http://www.archlinux.org linuxmania at gmail.com From eliott at cactuswax.net Mon Jan 21 02:13:58 2008 From: eliott at cactuswax.net (eliott) Date: Sun, 20 Jan 2008 23:13:58 -0800 Subject: [aur-dev] Testing branch updates In-Reply-To: <20080120112602.GA13008@neotuli.net> References: <20080120093806.GA12557@neotuli.net> <577f15290801200154q48b78324odbbd10f03201c4dd@mail.gmail.com> <20080120103917.GA12639@neotuli.net> <577f15290801200258r354ec578wf52912337fb97b1a@mail.gmail.com> <20080120112602.GA13008@neotuli.net> Message-ID: <428d921d0801202313v2c1c6795qa8e80bae9538568a@mail.gmail.com> On 1/20/08, Simo Leone wrote: > Also, quick note to anyone that happens to be testing... if you try to > upload a tar.gz or tar.bz2 (anything but a plain pkgbuild or .tar), > you'll find that it claims not to recognize the format. This is just a > limitation of the version of tar running on the dreamhost box, in > reality these other formats work just fine. FYI: I didn't get Callan's last two patches merged into my testing repo, so they are still 'in the wild'. http://archlinux.org/pipermail/aur-dev/2008-January/000078.html http://archlinux.org/pipermail/aur-dev/2008-January/000079.html From linuxmania at gmail.com Mon Jan 21 12:26:35 2008 From: linuxmania at gmail.com (Giovanni Scafora) Date: Mon, 21 Jan 2008 18:26:35 +0100 Subject: [aur-dev] Call for translations In-Reply-To: <20080120221548.GA13710@neotuli.net> References: <20080120221548.GA13710@neotuli.net> Message-ID: 2008/1/20, Simo Leone : > A few of our translations have a couple missing strings. If you guys > could take a look and reply with updates, that'd be awesome.e Hi guys, here's updated italian translation. Thanks. -- Giovanni Scafora Arch Linux Trusted User (voidnull) http://www.archlinux.org linuxmania at gmail.com -------------- next part -------------- A non-text attachment was scrubbed... Name: 0046-Updated-Italian-translation.patch.gz Type: application/x-gzip Size: 1774 bytes Desc: not available URL: From simo at archlinux.org Mon Jan 21 17:04:25 2008 From: simo at archlinux.org (Simo Leone) Date: Mon, 21 Jan 2008 16:04:25 -0600 Subject: [aur-dev] Testing branch updates In-Reply-To: <428d921d0801202313v2c1c6795qa8e80bae9538568a@mail.gmail.com> References: <20080120093806.GA12557@neotuli.net> <577f15290801200154q48b78324odbbd10f03201c4dd@mail.gmail.com> <20080120103917.GA12639@neotuli.net> <577f15290801200258r354ec578wf52912337fb97b1a@mail.gmail.com> <20080120112602.GA13008@neotuli.net> <428d921d0801202313v2c1c6795qa8e80bae9538568a@mail.gmail.com> Message-ID: <20080121220425.GB14528@archlinux.org> On Sun, Jan 20, 2008 at 11:13:58PM -0800, eliott wrote: > On 1/20/08, Simo Leone wrote: > > Also, quick note to anyone that happens to be testing... if you try to > > upload a tar.gz or tar.bz2 (anything but a plain pkgbuild or .tar), > > you'll find that it claims not to recognize the format. This is just a > > limitation of the version of tar running on the dreamhost box, in > > reality these other formats work just fine. > > FYI: I didn't get Callan's last two patches merged into my testing > repo, so they are still 'in the wild'. > > http://archlinux.org/pipermail/aur-dev/2008-January/000078.html > http://archlinux.org/pipermail/aur-dev/2008-January/000079.html Yup, I got those, thanks! -S -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available URL: From matthias at archlinux.de Mon Jan 21 07:44:01 2008 From: matthias at archlinux.de (Matthias Gorissen) Date: Mon, 21 Jan 2008 13:44:01 +0100 Subject: [aur-dev] Call for translations Message-ID: <200801211344.02144.matthias@archlinux.de> It may be my fault, but somehow I seem to be unable to get access to your git-repo: [tlaloc at archlinux archlinux]$ git-clone http://projects.archlinux.org/git/aur-git Initialized empty Git repository in /home/tlaloc/archlinux/aur-git/.git/ Cannot get remote repository information. Perhaps git-update-server-info needs to be run there? I would like to have a (handy) look at the de-version, though ... Best regards, Matt From linuxmania at gmail.com Mon Jan 21 17:11:56 2008 From: linuxmania at gmail.com (Giovanni Scafora) Date: Mon, 21 Jan 2008 23:11:56 +0100 Subject: [aur-dev] Call for translations In-Reply-To: <200801211344.02144.matthias@archlinux.de> References: <200801211344.02144.matthias@archlinux.de> Message-ID: 2008/1/21, Matthias Gorissen : > It may be my fault, but somehow I seem to be unable to get access to your > git-repo: > > [tlaloc at archlinux archlinux]$ git-clone > http://projects.archlinux.org/git/aur-git > Initialized empty Git repository in /home/tlaloc/archlinux/aur-git/.git/ > Cannot get remote repository information. > Perhaps git-update-server-info needs to be run there? git clone http://projects.archlinux.org/git/aur.git aur-git cd aur-git git checkout -b testing origin/testing -- Giovanni Scafora Arch Linux Trusted User (voidnull) http://www.archlinux.org linuxmania at gmail.com From wizzomafizzo at gmail.com Wed Jan 23 07:34:10 2008 From: wizzomafizzo at gmail.com (Callan Barrett) Date: Wed, 23 Jan 2008 21:34:10 +0900 Subject: [aur-dev] [PATCH] Turn more and less buttons into links Message-ID: <1201091650-10493-1-git-send-email-wizzomafizzo@gmail.com> This is to (at least) fix the more and less buttons which weren't working because of the drop down menu for actions Signed-off-by: Callan Barrett --- web/lib/pkgfuncs.inc | 28 ++++++++++++---------------- 1 files changed, 12 insertions(+), 16 deletions(-) -------------- next part -------------- A non-text attachment was scrubbed... Name: 258653b3beb52870ae295d610b0aac66e4cfef3c.diff Type: text/x-patch Size: 2532 bytes Desc: not available URL: From simo at archlinux.org Wed Jan 23 12:27:43 2008 From: simo at archlinux.org (Simo Leone) Date: Wed, 23 Jan 2008 11:27:43 -0600 Subject: [aur-dev] [PATCH] Fix login error and translation bug In-Reply-To: <1200557040-28734-1-git-send-email-wizzomafizzo@gmail.com> References: <1200557040-28734-1-git-send-email-wizzomafizzo@gmail.com> Message-ID: <20080123172743.GA19951@neotuli.net> On Thu, Jan 17, 2008 at 05:04:00PM +0900, Callan Barrett wrote: > > Fixes a login error where entering nothing would result in the login message > "Incorrect password for username, ." and changes the translation "TU" to > "Trusted User" so the menu bar on the accounts page doesn't bug up (we need a > new translation system :((() > > Signed-off-by: Callan Barrett Applied. -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available URL: From simo at archlinux.org Wed Jan 23 12:27:59 2008 From: simo at archlinux.org (Simo Leone) Date: Wed, 23 Jan 2008 11:27:59 -0600 Subject: [aur-dev] [PATCH] Turn action bar into drop box In-Reply-To: <1200586272-18378-1-git-send-email-wizzomafizzo@gmail.com> References: <1200586272-18378-1-git-send-email-wizzomafizzo@gmail.com> Message-ID: <20080123172759.GB19951@neotuli.net> On Fri, Jan 18, 2008 at 01:11:12AM +0900, Callan Barrett wrote: > > Moves the action bar down to the bottom right of the search results and turns it > into a drop-down selection box. > Applied -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available URL: From simo at archlinux.org Wed Jan 23 12:28:51 2008 From: simo at archlinux.org (Simo Leone) Date: Wed, 23 Jan 2008 11:28:51 -0600 Subject: [aur-dev] [PATCH] Turn more and less buttons into links In-Reply-To: <1201091650-10493-1-git-send-email-wizzomafizzo@gmail.com> References: <1201091650-10493-1-git-send-email-wizzomafizzo@gmail.com> Message-ID: <20080123172851.GC19951@neotuli.net> On Wed, Jan 23, 2008 at 09:34:10PM +0900, Callan Barrett wrote: > > This is to (at least) fix the more and less buttons which weren't working > because of the drop down menu for actions > > Signed-off-by: Callan Barrett Applied with minor changes to make sure people can't pass in bogus values like starting from package #-4524325. -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available URL: