[aur-dev] [PATCH] Remove unnecessary atype and uid lookup from package_details()
Dan McGee
dan at archlinux.org
Thu Aug 11 10:04:01 EDT 2011
These were never used in the function. Where they are used is in the
pkg_details.php template, so move them closer to their actual usage so
as not to confuse poor programmers such as myself.
Signed-off-by: Dan McGee <dan at archlinux.org>
---
web/lib/pkgfuncs.inc.php | 3 ---
web/template/pkg_details.php | 2 ++
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/web/lib/pkgfuncs.inc.php b/web/lib/pkgfuncs.inc.php
index 6e86470..4243991 100644
--- a/web/lib/pkgfuncs.inc.php
+++ b/web/lib/pkgfuncs.inc.php
@@ -301,9 +301,6 @@ function pkgname_is_blacklisted($name, $dbh=NULL) {
# display package details
#
function package_details($id=0, $SID="", $dbh=NULL) {
- $atype = account_from_sid($SID);
- $uid = uid_from_sid($SID);
-
if(!$dbh) {
$dbh = db_connect();
}
diff --git a/web/template/pkg_details.php b/web/template/pkg_details.php
index 5239123..c03493d 100644
--- a/web/template/pkg_details.php
+++ b/web/template/pkg_details.php
@@ -1,4 +1,6 @@
<?php
+$atype = account_from_sid($SID);
+$uid = uid_from_sid($SID);
$pkgid = intval($_REQUEST['ID']);
if ($uid == $row["MaintainerUID"] or
--
1.7.6
More information about the aur-dev
mailing list