[aur-dev] [PATCH 1/1] wrap mysql_real_escape_string in a function

[elij]

On Tue, May 17, 2011 at 8:58 AM, Lukas Fleischer
<archlinux at cryptocrack.de> wrote:
> On Mon, May 16, 2011 at 04:09:54PM -0700, elij wrote:
>> wrap mysql_real_escape_string in a wrapper function db_escape_string to ease
>> porting to other databases, and as another step to pulling more of the database
>> code into a central location.
>> ---
>>  web/html/account.php              |    2 +-
>>  web/html/addvote.php              |   10 +++++-----
>>  web/html/logout.php               |    2 +-
>>  web/html/passreset.php            |    4 ++--
>>  web/html/pkgsubmit.php            |   36 ++++++++++++++++++------------------
>>  web/html/voters.php               |    2 +-
>>  web/lib/acctfuncs.inc             |   26 +++++++++++++-------------
>>  web/lib/aur.inc                   |    7 +++++++
>>  web/lib/aurjson.class.php         |    8 ++++----
>>  web/lib/pkgfuncs.inc              |   12 ++++++------
>>  web/lib/stats.inc                 |    2 +-
>>  web/template/pkg_comment_form.php |    2 +-
>>  12 files changed, 60 insertions(+), 53 deletions(-)
>>
>
> What's the main difference between this one and the "use convenience
> wrapper for mysql_real_escape_string to aid database portability" patch?

ha! I forgot I had submitted that one. Last month was so long ago!
*rolls eyes at himself*

It appears that this time around I named the function
db_escape_string, which seems like it could be a bit better, as it
only escapes strings (it does not detect the input type and only
escape on string for example).

> You should also try to conform to some proper guidelines like [1] when
> formatting your commit messages. I'm well aware that lots of us don't (I
> don't even stick to the 50 characters summary line limit often, too) but
> you should at least try to wrap everything to 72 characters...

Hmm. Turns out my gitcommit.vim filetype plugin wasn't loading
properly (due to a config error on my part in my .vimrc). This has
been fixed, and should resolve the issue. I had assumed it was working
properly (because I reformat before writeout) and it simply wasn't
anymore.

> [1] http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html
>