[aur-dev] [PATCH 4/6] account_edit_form.php: Fix some XHTML errors

canyonknight canyonknight at gmail.com
Thu Oct 18 17:12:27 EDT 2012


* Add </option> close tags
* Add VI delimiter to selected option
* Add quotes to language codes

Signed-off-by: canyonknight <canyonknight at gmail.com>
---
 web/template/account_edit_form.php | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/web/template/account_edit_form.php b/web/template/account_edit_form.php
index 308913d..6c39d53 100644
--- a/web/template/account_edit_form.php
+++ b/web/template/account_edit_form.php
@@ -23,23 +23,25 @@
 			<label for="id_type"><?= __("Account Type") ?>:</label>
 			<select name="T" id="id_type">
 				<?php if ($T == "User"): ?>
-				<option value="1" selected><?= __("Normal user") ?>
+				<option value="1" selected="selected"><?= __("Normal user") ?></option>
 				<?php else: ?>
-				<option value="1"><?= __("Normal user") ?>
+				<option value="1"><?= __("Normal user") ?></option>
 				<?php endif; ?>
 				<?php if ($T == "Trusted User"): ?>
-				<option value="2" selected><?= __("Trusted user") ?>
+				<option value="2" selected="selected"><?= __("Trusted user") ?></option>
 				<?php else: ?>
-				<option value="2"><?= __("Trusted user") ?>
+				<option value="2"><?= __("Trusted user") ?></option>
 				<?php endif; ?>
 				<?php
 				# Only developers can make another account a developer
 				if ($UTYPE == "Developer"):
 				?>
 				<option value="3"
-				<?php $T == "Developer" ? print " selected>" : print ">";
+				<?php $T == "Developer" ? print " selected=\"selected\">" : print ">";
 				print __("Developer")."\n"; ?>
+				</option>
 				<?php endif; ?>
+
 			</select>
 		</p>
 
@@ -92,9 +94,9 @@
 	reset($SUPPORTED_LANGS);
 	while (list($code, $lang) = each($SUPPORTED_LANGS)) {
 		if ($L == $code) {
-			print "<option value=".$code." selected> ".$lang."\n";
+			print "<option value=\"".$code."\" selected=\"selected\"> ".$lang."</option>"."\n";
 		} else {
-			print "<option value=".$code."> ".$lang."\n";
+			print "<option value=\"".$code."\"> ".$lang."</option>"."\n";
 		}
 	}
 ?>
-- 
1.7.12.3



More information about the aur-dev mailing list