[aur-dev] [PATCH] Add direct links to each source file

[Janne Heß]

I'm really sorry. This happened while rewriting the patch after it
didn't apply anymore (I'm currently unable to access the repo where I
made the work in the first place).
I'll resubmit in a few minutes...

On 02/12/2017 05:25 PM, Lukas Fleischer wrote:
> On Sun, 12 Feb 2017 at 17:13:31, Janne Heß via aur-dev wrote:
>> Currently, each source file which is an external link (http://,
>> https://, ...) is a clickable link.
>> This commit extends the behaviour by making files from the repository
>> clickable as well. The link brings the user to the corresponding cgit
>> page.
>>
>> Also, the link to the PKGBUILD is altered to make the configuration
>> more consistent.
>>
>> Signed-off-by: Janne Heß <jannehess at gmail.com>
>> ---
>>  conf/config.proto            | 2 +-
>>  web/lib/pkgfuncs.inc.php     | 6 ++++--
>>  web/template/pkg_details.php | 3 ++-
>>  3 files changed, 7 insertions(+), 4 deletions(-)
>> [...]
>> diff --git a/web/template/pkg_details.php b/web/template/pkg_details.php
>> index 3269394..2fbdabf 100644
>> --- a/web/template/pkg_details.php
>> +++ b/web/template/pkg_details.php
>> @@ -1,6 +1,6 @@
>>  <?php
>>  
>> -$pkgbuild_uri = sprintf(config_get('options', 'pkgbuild_uri'), urlencode($row['BaseName']));
>> +$pkgbuild_uri = sprintf(config_get('options', 'source_file_uri'), 'PKGBUILD', urlencode($row['BaseName']));
>>  $log_uri = sprintf(config_get('options', 'log_uri'), urlencode($row['BaseName']));
>>  $snapshot_uri = sprintf(config_get('options', 'snapshot_uri'), urlencode($row['BaseName']));
>>  $git_clone_uri_anon = sprintf(config_get('options', 'git_clone_uri_anon'), htmlspecialchars($row['BaseName']));
>> @@ -300,6 +300,7 @@ endif;
>>                         <ul id="pkgsrcslist">
>>                                         <?php while (list($k, $src) = each($sources)): ?>
>>                                         <li><?= pkg_source_link($src[0], $src[1]) ?></li>
> 
> Looks like a spoke too soon. The line that is added below should
> actually replace the line above, right?
> 
>> +                                       <li><?= pkg_source_link($src[0], $src[1], urlencode($row['BaseName'])) ?></li>
>>                                         <?php endwhile; ?>
>>                         </ul>
>>                 </div>
>> -- 
>> 2.11.1

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/aur-dev/attachments/20170212/229c83fb/attachment.asc>