[pacman-dev] [PATCH] libalpm: avoid double free() in trans_free()

Aurelien Foret aurelien at archlinux.org
Mon Jan 2 02:47:29 EST 2006


VMiklos wrote:
> On Sun, Jan 01, 2006 at 02:01:03PM +0100, VMiklos <vmiklos at frugalware.org> wrote:
> no, i was wrong. sortbydeps() will only copy the pointers, what's why we
> only need FREELISTPTR() there
> 

I don't say FREELISTPKGS should be always used when dealing with 
trans->packages.

But, the point was to discuss your patch which basically calls 
FREELISTPTR instead of FREELISTPKGS from the trans_free function.
In this specific function, the latter _must_ be used (obviously if we're 
not in the case of a SYNC transaction).

Can you please confirm that the bug we are discussing is occurring with 
the code from the official ArchLinux CVS tree?

Thanks
--
Aurelien




More information about the pacman-dev mailing list