[pacman-dev] Fwd: CVS update of pacman-lib/lib/libalpm (remove.c)

[Roman Kyrylych]

2007/1/18, Aaron Griffin <aaronmgriffin at gmail.com>:
> On 1/18/07, Roman Kyrylych <roman.kyrylych at gmail.com> wrote:
> > Looks good for me (except that Gmail message text displaying sucks).
> > I used for diffs from sdl-cvs ML.
>
> Can you explain? I'm not on that ML.  There are a few scripts which do
> fancy colored diffs, but that requires HTML email and we all know
> plain text is superior :)

HTML messages are evil. >:-E

> I've come across alot of text-wrapping issues with gmail lately... I
> need to figure out if something can be done about that, or scrap gmail
> altogether....

I saw somewhere a nice set of CSS themes for Gmail that make it look
nicer, but don't remember now where there were. I think I'll made at
least fixed-width mod when I'll get very angry on gmail.
Dunno how to deal with those stupid wraps yet.


Here's the a part of a message from sdl-cvs ML:


Revision: 2911
Author:   pmandin
Date:     2006-11-13 12:34:18 -0800 (Mon, 13 Nov 2006)

Log Message:
-----------
Save/restore current video mode and palette

Modified Paths:
--------------
   trunk/SDL/src/video/xbios/SDL_xbios.c
   trunk/SDL/src/video/xbios/SDL_xbios.h
   trunk/SDL/src/video/xbios/SDL_xbiosmodes.c

Added Paths:
-----------
   trunk/SDL/src/video/xbios/SDL_xbiosmodes.h

Modified: trunk/SDL/src/video/xbios/SDL_xbios.c
===================================================================
--- trunk/SDL/src/video/xbios/SDL_xbios.c       2006-11-13 19:59:28
UTC (rev 2910)
+++ trunk/SDL/src/video/xbios/SDL_xbios.c       2006-11-13 20:34:18
UTC (rev 2911)
@@ -174,7 +174,7 @@
 {
    /* Save screensaver settings */

-    /* Init video mode list */
+    /* Init video mode list, save current video mode settings */
    SDL_XBIOS_InitModes(_this);

    return (0);
@@ -187,5 +187,6 @@

    /* Restore screensaver settings */

+    /* Restore previous video mode settings */
    SDL_XBIOS_QuitModes(_this);
 }

Modified: trunk/SDL/src/video/xbios/SDL_xbios.h
===================================================================
--- trunk/SDL/src/video/xbios/SDL_xbios.h       2006-11-13 19:59:28
UTC (rev 2910)
+++ trunk/SDL/src/video/xbios/SDL_xbios.h       2006-11-13 20:34:18
UTC (rev 2911)
@@ -29,8 +29,13 @@

. . . skipped . . .
Looks slightly better for me.
Though, as you may notice - this is generated from SVN (they swithched
to SVN before starting real work on SDL 1.3).

The only improvement I would like to see in pacman cvs reports - make this:
> ----------+
>  remove.c |   16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
>
>
> Index: pacman-lib/lib/libalpm/remove.c
> diff -u pacman-lib/lib/libalpm/remove.c:1.54
> pacman-lib/lib/libalpm/remove.c:1.55
> --- pacman-lib/lib/libalpm/remove.c:1.54        Thu Jan 18 11:04:05 2007
> +++ pacman-lib/lib/libalpm/remove.c     Thu Jan 18 12:04:25 2007

look like just
> --- pacman-lib/lib/libalpm/remove.c:1.54        Thu Jan 18 11:04:05 2007
> +++ pacman-lib/lib/libalpm/remove.c     Thu Jan 18 12:04:25 2007

because there is
>     Path: /home/cvs-pacman/pacman-lib/lib/libalpm
>
> Modified: remove.c (1.54 -> 1.55)

already.
But that's just cosmetics. :-)

-- 
Roman Kyrylych (Роман Кирилич)