[pacman-dev] [PATCH] small checkdeps speed-up

Xavier shiningxc at gmail.com
Sat Jan 12 11:45:15 EST 2008


Nagy Gabor wrote:
>> I'm curious how significant this speedup is. Do you possibly have
>> profiling data?
>>
> Hi!
>
> Well, nobody said this is significant speedup (see subject). I just
> killed a needless ~O(n^2) computing (where n is the number of packages
> in _pkgcache_). I didn't know how significant this speed-up is (don't
> forget about multiple checkdeps calls, see -Rc), but clearly, this is
> faster (-O(n^2) for every reversedeps==TRUE checkdeps call); and should
> be identical with the old code.
>

I like this patch anyway, not only because it makes the code a bit 
faster, but also because the code is clearer that way in my opinion.




More information about the pacman-dev mailing list