[pacman-dev] [PATCH] zsh completion: make $tmp local

Daniel Wallace danielwallace at gtmanfred.com
Mon Mar 18 01:46:55 EDT 2013


The tmp variable is conflicting with the $tmp variable in
${^fpath}/_main_complete(N) and which is used to complete all the
functions, and causing an error: command not found: for whatever was in
$tmp (which in this case is the last value in $words[@])

making it local fixes this.

Signed-off-by: Daniel Wallace <danielwallace at gtmanfred.com>
---
 contrib/zsh_completion.in | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/contrib/zsh_completion.in b/contrib/zsh_completion.in
index 8ad4a63..5096b8f 100644
--- a/contrib/zsh_completion.in
+++ b/contrib/zsh_completion.in
@@ -118,7 +118,6 @@ _pacman_action_help() {
 _pacman_action_none() {
 	_arguments -s : \
 		"$_pacman_opts_commands[@]"
-	return 0
 }
 
 # handles --query subcommand
@@ -320,6 +319,7 @@ _pacman_get_command() {
 # main dispatcher
 _pacman_zsh_comp() {
 	local -a args cmds;
+	local tmp
 	args=( ${${${(M)words:#-*}#-}:#-*} )
 	for tmp in $words; do
 		cmds+=("${${_pacman_opts_commands[(r)*$tmp\[*]%%\[*}#*\)}")
@@ -434,7 +434,6 @@ _pacman_zsh_comp() {
 			esac
 			;;
 	esac
-	return 0
 }
 
 _key_shortopts=(
-- 
1.8.2



More information about the pacman-dev mailing list