[pacman-dev] [PATCH] Remove -fgnu89-inline from compile options

Dan McGee dan at archlinux.org
Thu Jan 2 13:37:09 EST 2014


This was a hack done by me in commit d8e88aa0175fd back in 2007 that is
no longer necessary, given a sufficiently smart compiler and one that
supports the inline keyword.

Signed-off-by: Dan McGee <dan at archlinux.org>
---
 configure.ac            |  2 --
 lib/libalpm/Makefile.am |  3 ---
 m4/acinclude.m4         | 20 --------------------
 3 files changed, 25 deletions(-)

diff --git a/configure.ac b/configure.ac
index cfcc8d1..8a7e9d4 100644
--- a/configure.ac
+++ b/configure.ac
@@ -316,8 +316,6 @@ AC_CHECK_MEMBERS([struct statfs.f_flags],,,[[#include <sys/param.h>
 
 # Check if we can use symbol visibility support in GCC
 GCC_VISIBILITY_CC
-# Check if we have -fgnu89-inline flag
-GCC_GNU89_INLINE_CC
 
 # Host-dependant definitions
 INODECMD="stat -c '%i %n'"
diff --git a/lib/libalpm/Makefile.am b/lib/libalpm/Makefile.am
index 171bc46..67be2b1 100644
--- a/lib/libalpm/Makefile.am
+++ b/lib/libalpm/Makefile.am
@@ -18,9 +18,6 @@ else
 AM_CFLAGS += -fvisibility=internal
 endif
 endif
-if ENABLE_GNU89_INLINE_CC
-AM_CFLAGS += -fgnu89-inline
-endif
 
 pkgconfigdir = $(libdir)/pkgconfig
 pkgconfig_DATA = libalpm.pc
diff --git a/m4/acinclude.m4 b/m4/acinclude.m4
index 294507e..15bb31e 100644
--- a/m4/acinclude.m4
+++ b/m4/acinclude.m4
@@ -87,26 +87,6 @@ AC_DEFUN([GCC_VISIBILITY_CC],[
   fi
 ])
 
-dnl GCC_GNU89_INLINE_CC
-dnl checks -fgnu89-inline with the C compiler, if it exists then defines
-dnl ENABLE_GNU89_INLINE_CC in both configure script and Makefiles
-AC_DEFUN([GCC_GNU89_INLINE_CC],[
-  AC_LANG_ASSERT(C)
-  if test "X$CC" != "X"; then
-    AC_CACHE_CHECK([for -fgnu89-inline],
-    gnu89_inline_cv_cc,
-    [ gnu89_inline_old_cflags="$CFLAGS"
-      CFLAGS="$CFLAGS -fgnu89-inline"
-      AC_TRY_COMPILE(,, gnu89_inline_cv_cc=yes, gnu89_inline_cv_cc=no)
-      CFLAGS="$gnu89_inline_old_cflags"
-    ])
-    if test $gnu89_inline_cv_cc = yes; then
-      AC_DEFINE([ENABLE_GNU89_INLINE_CC], 1, [Define if gnu89 inlining semantics should be used.])
-    fi
-    AM_CONDITIONAL([ENABLE_GNU89_INLINE_CC], test "x$gnu89_inline_cv_cc" = "xyes")
-  fi
-])
-
 dnl CFLAGS_ADD(PARAMETER, VARIABLE)
 dnl Adds parameter to VARIABLE if the compiler supports it.  For example,
 dnl CFLAGS_ADD([-Wall],[WARN_FLAGS]).
-- 
1.8.5.2



More information about the pacman-dev mailing list