[pacman-dev] [PATCH 8/8] alpm: export *_free functions

Allan McRae allan at archlinux.org
Wed Jan 29 23:46:01 EST 2014


On 07/01/14 02:52, Andrew Gregory wrote:
> Front-ends should be able to free memory that alpm hands them.
> 
> Signed-off-by: Andrew Gregory <andrew.gregory.8 at gmail.com>
> ---
>  lib/libalpm/alpm.h     |  4 ++++
>  lib/libalpm/conflict.c |  6 +++---
>  lib/libalpm/conflict.h |  3 ---
>  lib/libalpm/deps.c     |  8 ++++----
>  lib/libalpm/deps.h     |  1 -
>  lib/libalpm/remove.c   |  6 +++---
>  lib/libalpm/sync.c     | 14 +++++++-------
>  src/pacman/remove.c    |  3 ++-
>  src/pacman/sync.c      | 13 ++++++++-----
>  9 files changed, 31 insertions(+), 27 deletions(-)
> 
> diff --git a/lib/libalpm/alpm.h b/lib/libalpm/alpm.h
> index 5628527..28ae851 100644
> --- a/lib/libalpm/alpm.h
> +++ b/lib/libalpm/alpm.h
> @@ -1351,6 +1351,10 @@ enum alpm_caps {
>  const char *alpm_version(void);
>  enum alpm_caps alpm_capabilities(void);
>  
> +void alpm_fileconflict_free(alpm_fileconflict_t *conflict);
> +void alpm_depmiss_free(alpm_depmissing_t *miss);

alpm_depmissing_free()  - no point save three letters

I was looking for a better position in the head to group these, but did
not really see anything.  Unless someone else has a good idea, I guess
they will be fine there.

Rest of patch was fine.


More information about the pacman-dev mailing list