[pacman-dev] [PATCH] Added better colourisation support for certain operations: * Package Information: -Si and -Qi * Install Group: -S (group)

[Allan McRae]

On 09/04/16 11:01, Xavion wrote:
> Hi Allan,
> 
> Yes.  Adding a colon to pacman's output is not part of "better
>> colourisation support".
> 
> 
>> Yes, -Si and -Qi should be together, the other two changes should be
>> done individually.
> 
> 
>> Please make the following changes before you resubmit:
>> - begin your commit message(s) with a *brief* one-line summary; see
>>   http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html
>> - move variable declarations to the top of their scope as described in
>>   HACKING
>> - avoid allocating a string just to immediately print it with fputs,
>>   just use fprintf
>>
> 
> You might have noticed that I incorporated all of Andrew's change requests
> and released four separate patches on March 28.  I haven't heard anything
> back from either of you since then.
> 
> Do I take that as an acceptance of my revised patches, or is it just a sign
> that no-one has looked at them yet?  If the former, does this mean that
> they're in the merge queue for the trunk?
> 

I have not had tome to sit down and do much patch review lately.  They
are in the queue.

A