[pacman-dev] [PATCH] libmakepkg/lint_config: fix lint_variable actually running the PKGBUILD lint

[Allan McRae]

On 5/9/18 5:17 am, Eli Schwartz wrote:
> Due to a copy-paste error when initially implementing this, it actually
> uses a duplicate function name, usually resulting in lint_pkgbuild
> overwriting the function definition.
> 
> Then the PKGBUILD lint gets run twice, one time before the PKGBUILD is
> even sourced -- to potentially surprising results, like erroring out on
> a pre-existing shell definition that doesn't match our expectations.
> 
> Seen in the wild with lint_config triggering an error for
> 'declare -x arch="foo"'
> 
> Signed-off-by: Eli Schwartz <eschwartz at archlinux.org>
> ---

Ack.